perf(linter): Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types by connorshea · Pull Request #23871 · oxc-project/oxc

connorshea · 2026-06-27T17:45:48Z

Generated with Claude Code, reviewed and tested by me.

Similar concept to #23868 and #23867, gates the following rules behind specific AST Nodes in their run methods to ensure that the rules are only applied when the corresponding AST Node is present.

Most of these regressed when the jest-vitest rules were split into separate rule files, and the AST Node codegen isn't smart enough to handle the separation, so the codegen ran these rules on every node in the entire codebase.

Narrow each rule's run to the node kinds it actually handles so codegen generates the correct NODE_TYPES:

jest/vitest require-hook -> [CallExpression, Program]
jest/vitest prefer-mock-promise-shorthand -> [CallExpression]
jest/vitest prefer-mock-return-shorthand -> [CallExpression]

On the vscode codebase, this cuts each rule's invocations from 15.25M to 870-880K (~17x fewer calls) with no behavior change.

Before:

Rule timings:
Rule                                   Time (ms)  Relative     Calls  Source
------------------------------------  ----------  --------  --------  ------
jest/require-hook                        250.566     15.6%  15251059  native
vitest/require-hook                      247.498     15.4%  15251059  native
jest/prefer-mock-promise-shorthand       223.433     13.9%  15251059  native
jest/prefer-mock-return-shorthand        222.515     13.8%  15251059  native
vitest/prefer-mock-promise-shorthand     219.438     13.6%  15251059  native
vitest/prefer-mock-return-shorthand      218.652     13.6%  15251059  native

After:

Rule timings:
Rule                                   Time (ms)  Relative   Calls  Source
------------------------------------  ----------  --------  ------  ------
jest/require-hook                         92.802     37.9%  881757  native
vitest/require-hook                       79.677     32.5%  881757  native
jest/prefer-mock-promise-shorthand        19.238      7.9%  870119  native
jest/prefer-mock-return-shorthand         16.029      6.5%  870119  native
vitest/prefer-mock-return-shorthand       15.878      6.5%  870119  native
vitest/prefer-mock-promise-shorthand      13.962      5.7%  870119  native

Overall: 91,506,354 calls down to 5,243,990 calls, a 94.3% reduction.

I also tried this change with promise/always-return, which has the same problem, but changing it resulted in a very minor difference in the code behavior for the VS Code repo (which our tests did not catch), and so I left that alone for now.

All of these were verified by the tests passing and the violations before and after matching on the VS Code codebase.

The one downside here is that the rules now duplicate the node.kind() guard check that exists in the run method each one calls. We can also remove the guards from the shared run methods if preferred.

…es to relevant node types These rules delegate their `run` logic to shared functions, so the linter codegen could not infer which AST node types they act on and defaulted to `NODE_TYPES = None`, running them on every node. Narrow each rule's `run` to the node kinds it actually handles so codegen generates the correct `NODE_TYPES`: - jest/vitest require-hook -> [CallExpression, Program] - jest/vitest prefer-mock-promise-shorthand -> [CallExpression] - jest/vitest prefer-mock-return-shorthand -> [CallExpression] On the vscode codebase this cuts each rule's invocations from ~15.25M to ~870K (~17x fewer calls) with no behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

codspeed-hq · 2026-06-27T17:54:18Z

Merging this PR will improve performance by 4.51%

⚡ 4 improved benchmarks
✅ 1 untouched benchmark
⏩ 66 skipped benchmarks¹

Performance Changes

	Mode	Benchmark	`BASE`	`HEAD`	Efficiency
⚡	Simulation	`linter[kitchen-sink.tsx]`	219 ms	207.1 ms	+5.73%
⚡	Simulation	`linter[binder.ts]`	34.3 ms	32.8 ms	+4.58%
⚡	Simulation	`linter[react.development.js]`	15.8 ms	15.2 ms	+3.88%
⚡	Simulation	`linter[App.tsx]`	108.3 ms	104.2 ms	+3.85%

Tip

Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.

_{Comparing fix-every-node (a1e7862) with main (aa1ad74)}

66 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

# Oxlint ### 💥 BREAKING CHANGES - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) ### 🚀 Features - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - 1c8f50c linter: Add schema for `eslint/no-restricted-import` (#23642) (Sysix) ### 🐛 Bug Fixes - 7cb85c4 linter/eslint/no-negated-condition: Add autofix for negated conditions (#23825) (Yagiz Nizipli) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d891990 linter/jsx-a11y/role-supports-aria-props: Ignore nullish prop values (#23865) (Mikhail Baev) - 94b6599 linter: Deduplicate missing plugin errors (#23853) (camc314) - eff3eff linter/oxc/branches-sharing-code: Avoid else-if false positives (#23843) (camc314) - 2a2d3b9 linter/eslint/prefer-destructuring: Skip `AssignmentExpression` autofixes (#23818) (camc314) - ddc24ae linter/eslint/id-length: Respect checkGeneric for mapped type keys (#23802) (bab) - cd89202 linter/react/exhaustive-deps: Skip wrapper expression when analyzing hook initializers (#23793) (camc314) - 20e8285 linter/unicorn/prefer-native-coercion-function: Allow ts type predicates (#23774) (camc314) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) - 52032cf linter: Newline-terminate tsgolint errors (#23762) (Mikhail Baev) - 368fda7 linter/eslint/no-warning-comments: Avoid dropping generated regex patterns (#23741) (camc314) - ce44fbd linter/valid-title: Escape disallowed words regex (#23742) (camc314) - 3100d11 linter/prefer-called-exactly-once-with: Avoid out-of-bounds slice panic at end of file (#23625) (Jerry Zhao) - 742be36 refactor/node/handle-callback-err: Reject invalid regex config (#23740) (camc314) - d7be179 linter/eslint/no-restricted-globals: Handle shadowed locals (#23736) (camc314) - b3b1ff8 linter/vitest/expect-expect: Handle global vitest detection correctly (#23734) (camc314) ### ⚡ Performance - 68f9472 linter/jsx-a11y: Skip lowercasing non-aria attribute names (#23906) (Lawrence Lin) - b9312b4 linter/unicorn/prefer-export-from: Use keyed binding lookup (#23893) (Marius Schulz) - cd5204e linter/typescript/no-unsafe-declaration-merging: Use keyed binding lookup (#23894) (Marius Schulz) - e948498 linter/eslint/prefer-named-capture-group: Only dispatch for relevant node types (#23868) (Connor Shea) - 4ac7a8e linter/eslint/max-depth: Derive node types (#23896) (Connor Shea) - daeed09 linter/eslint/no-restricted-globals: Only scan unresolved references (#23890) (camc314) - e808514 linter/jest-vitest: Speed up no-standalone-expect (#23883) (camc314) - 8b165e5 linter/react/exhaustive-deps: Skip non-reactive calls early (#23882) (camc314) - 54005e7 linter/eslint/no-unused-vars: Precompute exported bindings (#23881) (camc314) - 9bc2f8c linter/unicorn/prefer-number-properties: Speed up global checks (#23880) (camc314) - 4ff104f linter: Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types (#23871) (Connor Shea) - cc2213b linter: Run `no-underscore-dangle` only when relevant node types are present (#23867) (Connor Shea) - 3e55c21 linter/promise/always-return: Narrow to function node types (#23878) (Connor Shea) - 7136182 linter/jest-vitest: Speed up no-commented-out-tests (#23864) (camc314) - f138264 linter/eslint/no-script-url: Match javascript: prefix without allocating (#23861) (Lawrence Lin) - 7ef6895 linter/react/no-array-index-key: Delay index symbol lookup (#23857) (camc314) - 26bc171 linter/react/no-array-index-key: Match callback methods directly (#23856) (camc314) - 44fbbda linter/jsx-a11y/interactive-supports-focus: Check cheap conditions first (#23854) (camc314) - 84a5aa3 linter/eslint/no-extend-native: Skip lowercase references early (#23851) (camc314) - 88a74b2 linter/eslint/no-nonoctal-decimal-escape: Scan decimal escapes as bytes (#23850) (camc314) - fca69a8 linter: Skip traversal without this expressions (#23845) (camc314) - 838fd63 linter: Reduce preallocation for per-file diagnostics `Vec` (#23705) (Marius Schulz) - 417b506 linter/typescript/array-type: Remove full source text clone (#23751) (Marius Schulz) ### 📚 Documentation - 57e4469 linter/unicorn: Update prefer-dom-node-text-content rationale (#23933) (Mikhail Baev) - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - 259e0cd oxfmt,formatter_graphql: [**BREAKING**] Support draft syntax with removing prettier fallback (#23326) (leaysgur) - accbc49 oxfmt: [**BREAKING**] Format `parser:css,less,scss` files + css-in-js by `oxc_formatter_css` (#23321) (leaysgur) ### 🚀 Features - dffa4b3 formatter_css: Implement `oxc_formatter_css` (#23320) (leaysgur) - 01de9ec oxfmt: Format `parser:graphql` files by `oxc_formatter_graphql` (#23318) (leaysgur) - 4e66212 formatter_graphql: Implement oxc_formatter_graphql (#23317) (leaysgur) ### 🐛 Bug Fixes - 67325ae formatter_css: Handle frontmatter language (#23819) (leaysgur) - 3f355e5 formatter_graphql: Improve major prettier diffs (#23419) (leaysgur) - 48e2d78 formatter_css: Improve major prettier diffs (#23327) (leaysgur) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) ### ⚡ Performance - 4ddcba0 formatter_core: Add printable-ASCII fast path to TextWidth (#23913) (Lawrence Lin) ### 📚 Documentation - b4d0dc9 oxfmt,formatter,formatter_css,formatter_core: Update AGENTS.md (#23814) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

…n on specific node types (#23871) Generated with Claude Code, reviewed and tested by me. Similar concept to #23868 and #23867, gates the following rules behind specific AST Nodes in their `run` methods to ensure that the rules are only applied when the corresponding AST Node is present. Most of these regressed when the jest-vitest rules were split into separate rule files, and the AST Node codegen isn't smart enough to handle the separation, so the codegen ran these rules on every node in the entire codebase. Narrow each rule's `run` to the node kinds it actually handles so codegen generates the correct `NODE_TYPES`: - jest/vitest require-hook -> [CallExpression, Program] - jest/vitest prefer-mock-promise-shorthand -> [CallExpression] - jest/vitest prefer-mock-return-shorthand -> [CallExpression] On the vscode codebase, this cuts each rule's invocations from 15.25M to 870-880K (~17x fewer calls) with no behavior change. Before: ``` Rule timings: Rule Time (ms) Relative Calls Source ------------------------------------ ---------- -------- -------- ------ jest/require-hook 250.566 15.6% 15251059 native vitest/require-hook 247.498 15.4% 15251059 native jest/prefer-mock-promise-shorthand 223.433 13.9% 15251059 native jest/prefer-mock-return-shorthand 222.515 13.8% 15251059 native vitest/prefer-mock-promise-shorthand 219.438 13.6% 15251059 native vitest/prefer-mock-return-shorthand 218.652 13.6% 15251059 native ``` After: ``` Rule timings: Rule Time (ms) Relative Calls Source ------------------------------------ ---------- -------- ------ ------ jest/require-hook 92.802 37.9% 881757 native vitest/require-hook 79.677 32.5% 881757 native jest/prefer-mock-promise-shorthand 19.238 7.9% 870119 native jest/prefer-mock-return-shorthand 16.029 6.5% 870119 native vitest/prefer-mock-return-shorthand 15.878 6.5% 870119 native vitest/prefer-mock-promise-shorthand 13.962 5.7% 870119 native ``` Overall: 91,506,354 calls down to 5,243,990 calls, a 94.3% reduction. I also tried this change with promise/always-return, which has the same problem, but changing it resulted in a very minor difference in the code behavior for the VS Code repo (which our tests did not catch), and so I left that alone for now. All of these were verified by the tests passing and the violations before and after matching on the VS Code codebase. The one downside here is that the rules now duplicate the `node.kind()` guard check that exists in the `run` method each one calls. We can also remove the guards from the shared `run` methods if preferred. Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Cameron <cameron.clark@hey.com>

# Oxlint ### 💥 BREAKING CHANGES - 88f4455 str: [**BREAKING**] `Str` and `Ident` methods take `&GetAllocator` (#23781) (overlookmotel) ### 🚀 Features - f2091b3 ast: Unify old and new `AstBuilder`s (#23875) (overlookmotel) - 1c8f50c linter: Add schema for `eslint/no-restricted-import` (#23642) (Sysix) ### 🐛 Bug Fixes - 7cb85c4 linter/eslint/no-negated-condition: Add autofix for negated conditions (#23825) (Yagiz Nizipli) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d891990 linter/jsx-a11y/role-supports-aria-props: Ignore nullish prop values (#23865) (Mikhail Baev) - 94b6599 linter: Deduplicate missing plugin errors (#23853) (camc314) - eff3eff linter/oxc/branches-sharing-code: Avoid else-if false positives (#23843) (camc314) - 2a2d3b9 linter/eslint/prefer-destructuring: Skip `AssignmentExpression` autofixes (#23818) (camc314) - ddc24ae linter/eslint/id-length: Respect checkGeneric for mapped type keys (#23802) (bab) - cd89202 linter/react/exhaustive-deps: Skip wrapper expression when analyzing hook initializers (#23793) (camc314) - 20e8285 linter/unicorn/prefer-native-coercion-function: Allow ts type predicates (#23774) (camc314) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) - 52032cf linter: Newline-terminate tsgolint errors (#23762) (Mikhail Baev) - 368fda7 linter/eslint/no-warning-comments: Avoid dropping generated regex patterns (#23741) (camc314) - ce44fbd linter/valid-title: Escape disallowed words regex (#23742) (camc314) - 3100d11 linter/prefer-called-exactly-once-with: Avoid out-of-bounds slice panic at end of file (#23625) (Jerry Zhao) - 742be36 refactor/node/handle-callback-err: Reject invalid regex config (#23740) (camc314) - d7be179 linter/eslint/no-restricted-globals: Handle shadowed locals (#23736) (camc314) - b3b1ff8 linter/vitest/expect-expect: Handle global vitest detection correctly (#23734) (camc314) ### ⚡ Performance - 68f9472 linter/jsx-a11y: Skip lowercasing non-aria attribute names (#23906) (Lawrence Lin) - b9312b4 linter/unicorn/prefer-export-from: Use keyed binding lookup (#23893) (Marius Schulz) - cd5204e linter/typescript/no-unsafe-declaration-merging: Use keyed binding lookup (#23894) (Marius Schulz) - e948498 linter/eslint/prefer-named-capture-group: Only dispatch for relevant node types (#23868) (Connor Shea) - 4ac7a8e linter/eslint/max-depth: Derive node types (#23896) (Connor Shea) - daeed09 linter/eslint/no-restricted-globals: Only scan unresolved references (#23890) (camc314) - e808514 linter/jest-vitest: Speed up no-standalone-expect (#23883) (camc314) - 8b165e5 linter/react/exhaustive-deps: Skip non-reactive calls early (#23882) (camc314) - 54005e7 linter/eslint/no-unused-vars: Precompute exported bindings (#23881) (camc314) - 9bc2f8c linter/unicorn/prefer-number-properties: Speed up global checks (#23880) (camc314) - 4ff104f linter: Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types (#23871) (Connor Shea) - cc2213b linter: Run `no-underscore-dangle` only when relevant node types are present (#23867) (Connor Shea) - 3e55c21 linter/promise/always-return: Narrow to function node types (#23878) (Connor Shea) - 7136182 linter/jest-vitest: Speed up no-commented-out-tests (#23864) (camc314) - f138264 linter/eslint/no-script-url: Match javascript: prefix without allocating (#23861) (Lawrence Lin) - 7ef6895 linter/react/no-array-index-key: Delay index symbol lookup (#23857) (camc314) - 26bc171 linter/react/no-array-index-key: Match callback methods directly (#23856) (camc314) - 44fbbda linter/jsx-a11y/interactive-supports-focus: Check cheap conditions first (#23854) (camc314) - 84a5aa3 linter/eslint/no-extend-native: Skip lowercase references early (#23851) (camc314) - 88a74b2 linter/eslint/no-nonoctal-decimal-escape: Scan decimal escapes as bytes (#23850) (camc314) - fca69a8 linter: Skip traversal without this expressions (#23845) (camc314) - 838fd63 linter: Reduce preallocation for per-file diagnostics `Vec` (#23705) (Marius Schulz) - 417b506 linter/typescript/array-type: Remove full source text clone (#23751) (Marius Schulz) ### 📚 Documentation - 57e4469 linter/unicorn: Update prefer-dom-node-text-content rationale (#23933) (Mikhail Baev) - 3d61dea all: Correct capitalization in comments (#23887) (overlookmotel) ### 🛡️ Security - 3cdd18f deps: Update npm packages (#23690) (renovate[bot]) # Oxfmt ### 💥 BREAKING CHANGES - 259e0cd oxfmt,formatter_graphql: [**BREAKING**] Support draft syntax with removing prettier fallback (#23326) (leaysgur) - accbc49 oxfmt: [**BREAKING**] Format `parser:css,less,scss` files + css-in-js by `oxc_formatter_css` (#23321) (leaysgur) ### 🚀 Features - dffa4b3 formatter_css: Implement `oxc_formatter_css` (#23320) (leaysgur) - 01de9ec oxfmt: Format `parser:graphql` files by `oxc_formatter_graphql` (#23318) (leaysgur) - 4e66212 formatter_graphql: Implement oxc_formatter_graphql (#23317) (leaysgur) ### 🐛 Bug Fixes - 67325ae formatter_css: Handle frontmatter language (#23819) (leaysgur) - 3f355e5 formatter_graphql: Improve major prettier diffs (#23419) (leaysgur) - 48e2d78 formatter_css: Improve major prettier diffs (#23327) (leaysgur) - 8c07cad all: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate in tests (#23888) (overlookmotel) - f7d1f50 oxlint, oxfmt: Enable `disable_old_builder` Cargo feature for `oxc_ast` crate (#23886) (overlookmotel) - d86f60b lsp: Normalize user config path to watch pattern (#23723) (Sysix) ### ⚡ Performance - 4ddcba0 formatter_core: Add printable-ASCII fast path to TextWidth (#23913) (Lawrence Lin) ### 📚 Documentation - b4d0dc9 oxfmt,formatter,formatter_css,formatter_core: Update AGENTS.md (#23814) (leaysgur) Co-authored-by: Boshen <1430279+Boshen@users.noreply.github.com> Co-authored-by: Cameron <cameron.clark@hey.com>

connorshea requested a review from camc314 as a code owner June 27, 2026 17:45

github-actions Bot added the A-linter Area - Linter label Jun 27, 2026

camc314 self-assigned this Jun 28, 2026

camc314 approved these changes Jun 28, 2026

View reviewed changes

Merge branch 'main' into fix-every-node

a1e7862

camc314 merged commit 4ff104f into main Jun 28, 2026
28 checks passed

camc314 deleted the fix-every-node branch June 28, 2026 10:45

oxc-guard Bot mentioned this pull request Jun 29, 2026

release(apps): oxlint v1.72.0 && oxfmt v0.57.0 #23935

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf(linter): Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types#23871

perf(linter): Optimize `require-hook` and `prefer-mock-*` rules to run on specific node types#23871
camc314 merged 2 commits into
mainfrom
fix-every-node

connorshea commented Jun 27, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Jun 27, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

connorshea commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq Bot commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will improve performance by 4.51%

Performance Changes

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

connorshea commented Jun 27, 2026 •

edited

Loading

codspeed-hq Bot commented Jun 27, 2026 •

edited

Loading