Added support for istioctl kube-inject into a Pod#6784
Added support for istioctl kube-inject into a Pod#6784ymesika wants to merge 26 commits intoistio:release-1.0from ymesika:supportInjectIntoPod
Conversation
|
@ostromart since this is attempting to match the behavior of webhook, want to have a look? |
|
@nmittler @ostromart I was wondering whether this is a valid use case? |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #6784 +/- ##
============================================
+ Coverage 71% 71% +1%
============================================
Files 370 370
Lines 31850 31625 -225
============================================
- Hits 22428 22322 -106
+ Misses 8513 8410 -103
+ Partials 909 893 -16
Continue to review full report at Codecov.
|
|
Do we need this in 1.0 ? If so, please rebase. Seems a safe change. |
* fix bug so that destination.service.** attributes are collected (#6801) * remove unnecessary generated attributes finding. (#6785) * modify docker template files for proxyv2 (#6790) * Long-running testing improvements (#6800) * Add values for config map settings, including access log. More docs. * Updates and improvements for the stress-testing configs. * Add values for config map settings, including access log. (#6797) * Add values for config map settings, including access log. More docs. * Updates and improvements for the stress-testing configs. * Address review comments * Merged wrong files * Add the setup helm file - this change now depend on the previous PR. * Sync with remote, remove accidentally added files. * Another accidental file * SNI routing from sidecar to gateway with virtual services (#6402) * quick sni matching 1st pass with no refactoring of existing code * use shriram's api sha * quick pass at using tls block * add some validation * copyright * fix lint + remove deadcode * rename protocol tcp_tls -> tls * update back to istio/api master * remove accidentally added test file * add tls block to gateway logic * add todos * basic sni wildcard implementation * add tcp, fix problems with rbac, matching * better tcp + tls validation * address code review comments * remove out of date comment * update comments * fix compile error * use tcp proxy in tcp routing * add tcp routing e2e test * add forgotten vs config file + update description of test * Comments, bug fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * cleanup gateway tcp test Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * moving networking test yamls Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * tcp/tls tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * yaml fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix file switcheroo * port matches Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix authN plugin overwriting TLS context Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * more tests - route via egress gateway Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * yaml fixes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * initialize prom variables Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * split tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * final test fix hopefully Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * revert gateway tweaks Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* 503s: create DestinationRules before VirtualServices * Remove redundant route-rule-all-v1-mtls.yaml * Update the tests * Fix the bookinfo with auth test
* Updates to accommodate move of api/config/mcp to api/mcp. * Update dependencies. * Updated dep and reran due to linter problem. Reverted license file updates.
Signed-off-by: Kuat Yessenov <kuat@google.com>
With mixer disabled, continuous 503s occur.
* Add proxy version info to envoy metadata Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * use proxy tag as version Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * fix tests Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * update goldens * detect proxy version in pilot Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * added istioProxyVersion to helm values.yaml. updated tests * remove unused env var logic from istioctl * undo env var removal Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * encode version in Docker image Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * tweaks Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* add config validation metrics * s/gauge/counter
* add consistenthash support for httpheader * wires up source ip for hash policy * add support for port level traffic policies * only support port number for traffic policies port name is deprecated. traffic policies at the port level should only be inspected for port number when updating a route to use a hash policy. * bump istio/api Co-authored-by: Zachary Gershman <zgershman@pivotal.io> * stop ignoring port level settings on the subset * subset port level settings override top level * do not return hash policy when not requested Co-authored-by: Zachary Gershman <zgershman@pivotal.io>
* Mark gateway ports as H2 in k8s Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * set alpn protocol match Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * lint Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com> * undo code changes Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
* remove conversion tool * somewhat questionable pruning of tests without replacing them
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
This reverts commit 40b105d.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ymesika Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Replaced by #6903 |
|
@ymesika: The following test failed, say
DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
I'm out till 7/12 but @ayj can probably comment. |
Currently
istioctl kube-injectwon't inject the sidecar into a Pod object.However, when enabling the sidecar injector webhook and deploying a Pod object the webhook will inject the sidecar. This PR matches the behaviour.
Fixes #6731