Mark gateway ports as H2 in k8s#6887
Merged
rshriram merged 4 commits intoistio:release-1.0from Jul 6, 2018
Merged
Conversation
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Contributor
|
/lgtm |
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Collaborator
|
New changes are detected. LGTM label has been removed. |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #6887 +/- ##
============================================
+ Coverage 71% 71% +1%
============================================
Files 370 370
Lines 32045 31870 -175
============================================
- Hits 22586 22549 -37
+ Misses 8524 8386 -138
Partials 935 935
Continue to review full report at Codecov.
|
added 2 commits
July 6, 2018 15:30
Signed-off-by: Shriram Rajagopalan <shriramr@vmware.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rshriram, zachgersh, ZackButcher The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6872
Marking ports as http2 will cause CDS to emit h2 clusters for gateway ports.
Need to find another solution for HTTPS ports
Signed-off-by: Shriram Rajagopalan shriramr@vmware.com