Skip to content

Add galley config validation metrics and improved loggings#6827

Merged
rshriram merged 2 commits intoistio:release-1.0from
ayj:release-1.0-validation-metrics-v2
Jul 6, 2018
Merged

Add galley config validation metrics and improved loggings#6827
rshriram merged 2 commits intoistio:release-1.0from
ayj:release-1.0-validation-metrics-v2

Conversation

@ayj
Copy link
Copy Markdown
Contributor

@ayj ayj commented Jul 3, 2018

Add metrics and improved logging for configuration validation. Copied from #6762 (against master) which didn't make the 1.0 merge window.

@ayj ayj requested review from costinm, hklai, ozevren and rshriram July 3, 2018 20:55
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 3, 2018 •
edited
Loading

Codecov Report

Merging #6827 into release-1.0 will increase coverage by 1%.
The diff coverage is 85%.

Impacted file tree graph

@@             Coverage Diff             @@
##           release-1.0   #6827   +/-   ##
===========================================
+ Coverage           71%     71%   +1%     
===========================================
  Files              368     369    +1     
  Lines            31764   31734   -30     
===========================================
+ Hits             22428   22431    +3     
+ Misses            8418    8395   -23     
+ Partials           918     908   -10
Impacted Files Coverage Δ
galley/pkg/crd/validation/monitoring.go 100% <100%> (ø)
galley/pkg/crd/validation/webhook.go 80% <65%> (-1%) ⬇️
mixer/adapter/rbac/util.go 56% <0%> (-13%) ⬇️
mixer/adapter/signalfx/registry.go 86% <0%> (-5%) ⬇️
mixer/adapter/signalfx/cumulative.go 67% <0%> (-4%) ⬇️
mixer/adapter/cloudwatch/handler.go 87% <0%> (-2%) ⬇️
mixer/adapter/bypass/bypass.go 62% <0%> (-1%) ⬇️
mixer/adapter/kubernetesenv/cache.go 92% <0%> (-1%) ⬇️
mixer/adapter/servicecontrol/reportprocessor.go 79% <0%> (-1%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 68% <0%> (ø) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 344ed1f...0c1cfde. Read the comment docs.

@ozevren
Copy link
Copy Markdown
Contributor

ozevren commented Jul 3, 2018

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 3, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ayj, ozevren
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

Assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ayj ayj added this to the 1.0 milestone Jul 6, 2018
@rshriram rshriram merged commit ce843e3 into istio:release-1.0 Jul 6, 2018
This was referenced Jul 6, 2018
Closed
Closed
@ayj ayj deleted the release-1.0-validation-metrics-v2 branch October 17, 2018 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

@rshriram rshriram Awaiting requested review from rshriram

@hklai hklai Awaiting requested review from hklai

1 more reviewer

@ozevren ozevren ozevren approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ozevren ozevren

Labels

None yet

Projects

None yet

Milestone

1.0 - launched

Development

Successfully merging this pull request may close these issues.

5 participants

@ayj @ozevren @istio-testing @googlebot @rshriram