Skip to content

Added support for istioctl kube-inject into a Pod#6903

Merged
rshriram merged 4 commits intoistio:release-1.0from
ymesika:podInjection
Jul 7, 2018
Merged

Added support for istioctl kube-inject into a Pod#6903
rshriram merged 4 commits intoistio:release-1.0from
ymesika:podInjection

Conversation

@ymesika
Copy link
Copy Markdown
Member

@ymesika ymesika commented Jul 7, 2018

Currently istioctl kube-inject won't inject the sidecar into a Pod object.
However, when enabling the sidecar injector webhook and deploying a Pod object the webhook will inject the sidecar. This PR matches the behaviour.

Fixes #6731
Replaces #6784

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 7, 2018

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ymesika
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: ayj

Assign the PR to them by writing /assign @ayj in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ymesika ymesika mentioned this pull request Jul 7, 2018
Closed
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 7, 2018 •
edited
Loading

Codecov Report

Merging #6903 into release-1.0 will increase coverage by 1%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6903    +/-   ##
============================================
+ Coverage           71%     71%    +1%     
============================================
  Files              370     370            
  Lines            31850   31931    +81     
============================================
+ Hits             22428   22559   +131     
+ Misses            8513    8465    -48     
+ Partials           909     907     -2
Impacted Files Coverage Δ
pilot/pkg/kube/inject/initializer.go 100% <ø> (ø) ⬆️
istioctl/cmd/istioctl/kubeinject.go 44% <ø> (ø) ⬆️
pilot/pkg/kube/inject/inject.go 85% <100%> (+1%) ⬆️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-21%) ⬇️
mixer/adapter/rbac/util.go 56% <0%> (-6%) ⬇️
mixer/adapter/signalfx/signalfx.go 82% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/servicecontrol/checkprocessor.go 80% <0%> (ø) ⬇️
mixer/adapter/prometheus/prometheus.go 100% <0%> (ø) ⬆️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af5f327...8f13ca3. Read the comment docs.

@rshriram rshriram merged commit 3374582 into istio:release-1.0 Jul 7, 2018
@ymesika ymesika mentioned this pull request Jul 8, 2018
Closed
@ymesika ymesika deleted the podInjection branch July 9, 2018 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esnible esnible Awaiting requested review from esnible

@GregHanson GregHanson Awaiting requested review from GregHanson

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ymesika @istio-testing @rshriram @googlebot