Skip to content

Remove v1alpha1 -> v1alpha3 conversion tool#6901

Merged
costinm merged 2 commits intoistio:release-1.0from
ijsnellf:remove_conversion_tool
Jul 7, 2018
Merged

Remove v1alpha1 -> v1alpha3 conversion tool#6901
costinm merged 2 commits intoistio:release-1.0from
ijsnellf:remove_conversion_tool

Conversation

@ijsnellf
Copy link
Copy Markdown
Contributor

@ijsnellf ijsnellf commented Jul 6, 2018

Removes convenience tool for 1.0 release.

@ijsnellf ijsnellf requested review from costinm, esnible and rshriram July 6, 2018 22:28
@istio-testing istio-testing requested a review from liamawhite July 6, 2018 22:28
@ijsnellf ijsnellf mentioned this pull request Jul 6, 2018
Merged
@kyessenov
Copy link
Copy Markdown
Contributor

kyessenov commented Jul 6, 2018 via email

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 6, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ijsnellf, kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ijsnellf ijsnellf requested review from frankbu and linsun July 6, 2018 22:43
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 6, 2018 •
edited
Loading

Codecov Report

Merging #6901 into release-1.0 will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6901    +/-   ##
============================================
- Coverage           71%     71%   -<1%     
============================================
  Files              370     370            
  Lines            31663   31686    +23     
============================================
- Hits             22305   22300     -5     
- Misses            8433    8484    +51     
+ Partials           925     902    -23
Impacted Files Coverage Δ
istioctl/cmd/istioctl/main.go 38% <ø> (-4%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 62% <0%> (-18%) ⬇️
pilot/pkg/config/memory/monitor.go 82% <0%> (-9%) ⬇️
mixer/adapter/rbac/controller.go 47% <0%> (-6%) ⬇️
mixer/adapter/servicecontrol/distValueBuilder.go 88% <0%> (-3%) ⬇️
mixer/adapter/servicecontrol/utils.go 90% <0%> (-3%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (-1%) ⬇️
mixer/adapter/statsd/statsd.go 96% <0%> (-1%) ⬇️
mixer/adapter/bypass/bypass.go 61% <0%> (ø) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74b2e8...9e269c6. Read the comment docs.

@costinm costinm merged commit af5f327 into istio:release-1.0 Jul 7, 2018
@ijsnellf ijsnellf deleted the remove_conversion_tool branch July 9, 2018 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@costinm costinm Awaiting requested review from costinm

@esnible esnible Awaiting requested review from esnible

@rshriram rshriram Awaiting requested review from rshriram

@liamawhite liamawhite Awaiting requested review from liamawhite

@linsun linsun Awaiting requested review from linsun

@frankbu frankbu Awaiting requested review from frankbu

Assignees

@kyessenov kyessenov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ijsnellf @kyessenov @istio-testing @costinm @googlebot