Skip to content

deps: update proxy#6833

Merged
hklai merged 1 commit intoistio:release-1.0from
kyessenov:update_proxy_dep
Jul 5, 2018
Merged

deps: update proxy#6833
hklai merged 1 commit intoistio:release-1.0from
kyessenov:update_proxy_dep

Conversation

@kyessenov
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov commented Jul 3, 2018

Signed-off-by: Kuat Yessenov kuat@google.com

@kyessenov
update proxy
ebf1543 
Signed-off-by: Kuat Yessenov <kuat@google.com>
@istio-testing istio-testing requested review from hklai and ldemailly July 3, 2018 22:21
@hklai
Copy link
Copy Markdown
Contributor

hklai commented Jul 3, 2018

Need to wait for the proxy image to be published....

@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Jul 3, 2018

@hklai / @sebastienvas can you configure the bot to not ask me for reviews ? tia!

@hklai
Copy link
Copy Markdown
Contributor

hklai commented Jul 3, 2018 •
edited
Loading

@hklai / @sebastienvas can you configure the bot to not ask me for reviews ? tia!

@ldemailly probably remove yourself from the istio teams on github. -_-

@kyessenov
Copy link
Copy Markdown
Contributor Author

kyessenov commented Jul 3, 2018

/retest

@kyessenov
Copy link
Copy Markdown
Contributor Author

kyessenov commented Jul 3, 2018

can someone retrigger circle? I don't have access...

@rshriram rshriram closed this Jul 3, 2018
@rshriram rshriram reopened this Jul 3, 2018
@ldemailly
Copy link
Copy Markdown
Member

ldemailly commented Jul 4, 2018

@hklai there should be a way to stay in team
without the bot assigning reviews (leave mode or blacklist ...)

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 4, 2018

@costinm i believe this fixes the upgrade issue.

@kyessenov
Copy link
Copy Markdown
Contributor Author

kyessenov commented Jul 4, 2018

No it doesn't. @costinm wants to keep old envoy (0.8 or earlier) to accept new pilot configs. There are
a lot of new things in envoy which are likely to not be available in 0.8, but he is just nuking mixerfilter functionality at the moment. My change fixes 1.0 onwards.

@kyessenov
Copy link
Copy Markdown
Contributor Author

kyessenov commented Jul 4, 2018

Why is circle broken again? Need force merging...

@kyessenov
Copy link
Copy Markdown
Contributor Author

kyessenov commented Jul 5, 2018

@rshriram I can't login to circle, and it doesn't run the tests. Please force merge, we need the compatibility fix to be in 1.0.

hklai
hklai approved these changes Jul 5, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, kyessenov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hklai hklai merged commit b6d1e19 into istio:release-1.0 Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ldemailly ldemailly Awaiting requested review from ldemailly

1 more reviewer

@hklai hklai hklai approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@hklai hklai

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kyessenov @hklai @ldemailly @rshriram @istio-testing @googlebot