Skip to content

Updates to accommodate move of api/config/mcp to api/mcp.#6835

Merged
rshriram merged 3 commits intoistio:release-1.0from
ozevren:mcp-move
Jul 5, 2018
Merged

Updates to accommodate move of api/config/mcp to api/mcp.#6835
rshriram merged 3 commits intoistio:release-1.0from
ozevren:mcp-move

Conversation

@ozevren
Copy link
Copy Markdown
Contributor

@ozevren ozevren commented Jul 4, 2018 •
edited
Loading

  • Since this is the release branch, and the corresponding changes are in api/release-1.0 branch, I've updated Gokg.toml file to point istio.io/api dependency to api/release-1.0. This needs to be reverted back once 1.0 ships and changes get merged back into master.

@ozevren ozevren requested review from ayj, hklai and rshriram and removed request for cmluciano and geeknoid July 4, 2018 00:43
@ozevren ozevren mentioned this pull request Jul 4, 2018
Merged
ayj
ayj approved these changes Jul 4, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@ayj ayj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(will /lgtm again once PR is rebased against istio/api changes)

rshriram
rshriram approved these changes Jul 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@rshriram rshriram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 4, 2018

you have to update the dependencies (vendor stuff).

@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Jul 4, 2018

Yes, I am aware. I created this PR early since you asked for it in the previous one.

@istio-testing istio-testing removed the lgtm label Jul 4, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 4, 2018 •
edited
Loading

Codecov Report

Merging #6835 into release-1.0 will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           release-1.0   #6835    +/-   ##
============================================
- Coverage           71%     71%   -<1%     
============================================
  Files              370     370            
  Lines            31982   32093   +111     
============================================
+ Hits             22511   22589    +78     
- Misses            8545    8570    +25     
- Partials           926     934     +8
Impacted Files Coverage Δ
galley/pkg/mcp/server/server.go 87% <ø> (ø) ⬆️
galley/pkg/server/server.go 90% <ø> (ø) ⬆️
galley/pkg/mcp/client/client.go 71% <ø> (ø) ⬆️
galley/pkg/mcp/snapshot/inmemory.go 47% <ø> (ø) ⬆️
galley/pkg/runtime/state.go 100% <ø> (ø) ⬆️
galley/pkg/mcp/snapshot/snapshot.go 100% <ø> (ø) ⬆️
mixer/adapter/cloudwatch/cloudwatch.go 58% <0%> (-14%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 66% <0%> (-3%) ⬇️
...olarwinds/internal/papertrail/papertrail_logger.go 59% <0%> (-3%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 704a275...dc15d7b. Read the comment docs.

@ozevren ozevren mentioned this pull request Jul 4, 2018
Closed
@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Jul 4, 2018

Updated with dependencies. I've also updated the PR description to reflect what is going on.
@hklai I've opened #6849, to track a work that needs to be done to revert some changes back and assigned to you.

@ozevren
Copy link
Copy Markdown
Contributor Author

ozevren commented Jul 4, 2018 •
edited
Loading

Removed the comment about cobra/legal dependencies from PR description. After the linter has failed in the checkin gate, I ran depend.diff again (which seems to have updated my local dep). Rerunning dep ensure pruned those dependencies again.

cmluciano
cmluciano reviewed Jul 4, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 4, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ayj, cmluciano, ozevren, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit fcd8800 into istio:release-1.0 Jul 5, 2018
@ozevren ozevren deleted the mcp-move branch August 23, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hklai hklai Awaiting requested review from hklai

3 more reviewers

@cmluciano cmluciano cmluciano left review comments

@ayj ayj ayj approved these changes

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ayj ayj

@cmluciano cmluciano

@rshriram rshriram

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ozevren @rshriram @istio-testing @ayj @cmluciano @googlebot