proxy-status diff of what Pilot has not what it has sent to Envoy#6818
proxy-status diff of what Pilot has not what it has sent to Envoy#6818rshriram merged 2 commits intoistio:release-1.0from liamawhite:proxydiff
Conversation
Codecov Report
@@ Coverage Diff @@
## release-1.0 #6818 +/- ##
============================================
- Coverage 71% 71% -<1%
============================================
Files 368 369 +1
Lines 32078 32146 +68
============================================
+ Hits 22689 22717 +28
- Misses 8459 8493 +34
- Partials 930 936 +6
Continue to review full report at Codecov.
|
|
Is this something that is going to make it into 1.0? |
|
@zachgersh unless anyone has any objections, yes! 🙂 Its only actually a small change, most of the functionality is already there. |
| func (s *DiscoveryServer) generateRawRoutes(con *XdsConnection) ([]*xdsapi.RouteConfiguration, error) { | ||
| rc := make([]*xdsapi.RouteConfiguration, 0) | ||
| // TODO: Follow this logic for other xDS resources as well | ||
| // And cache/retrieve this info on-demand, not for every request from every proxy |
There was a problem hiding this comment.
Can we take this out? If someone needs this commented out code we can bring it back since its already in source control!
There was a problem hiding this comment.
These aren't my comments I just split out what we had into a separate file. We could ask whoever wrote them in the first place though I guess?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liamawhite, nmittler The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
After further discussions with users they are interested in what Pilot would send not what Pilot has sent. This is far more useful as it enables them to see if Pilot has propagated their Istio config changes to Envoy yet.