Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ijsnellf Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| binaryPath string | ||
| serviceCluster string | ||
| availabilityZone string | ||
| availabilityZone string // TODO: remove me? |
There was a problem hiding this comment.
do we want to remove the ability to set the AZ in pilot-agent?
| // - consul: defaults to 'instance.Datacenter' | ||
| // | ||
| // This is used by EDS to group the endpoints by AZ and by . | ||
| // TODO: remove me? |
There was a problem hiding this comment.
this is used by EDS here: https://github.com/istio/istio/blob/release-1.0/pilot/pkg/proxy/envoy/v2/eds.go#L216
There was a problem hiding this comment.
not sure if we want to keep the EDS logic for something in the future
Codecov Report
@@ Coverage Diff @@
## release-1.0 #6869 +/- ##
============================================
+ Coverage 71% 71% +1%
============================================
Files 370 370
Lines 32031 31766 -265
============================================
- Hits 22534 22362 -172
+ Misses 8561 8471 -90
+ Partials 936 933 -3
Continue to review full report at Codecov.
|
Removes the majority of the AZ logic.
Removing as part of: #6049. Once this is merged, it should be easy to nuke the v1 discovery server.