503s: create DestinationRules before VirtualServices#6705
503s: create DestinationRules before VirtualServices#6705rshriram merged 6 commits intorelease-1.0from
Conversation
rshriram
left a comment
There was a problem hiding this comment.
/lgtm
I think you need to update tests to refer to new files. Else tests won’t pass
| @@ -53,78 +53,3 @@ spec: | |||
| host: details | |||
| subset: v1 | |||
| --- | |||
There was a problem hiding this comment.
This file is now the same as route-rule-all-v1.yaml. Delete it?
There was a problem hiding this comment.
Good catch, removed.
| labels: | ||
| version: v1 | ||
| --- | ||
| --- |
Codecov Report
@@ Coverage Diff @@
## release-1.0 #6705 +/- ##
=============================================
- Coverage 71% 71% -<1%
=============================================
Files 370 354 -16
Lines 31886 30657 -1229
=============================================
- Hits 22363 21497 -866
+ Misses 8586 8314 -272
+ Partials 937 846 -91
Continue to review full report at Codecov.
|
|
thanks @rshriram will do |
|
I notice in fact the mixer test still exercise v1 rule from /kube directory. We need to change them to exercise v1alpha3 rules from the routing directory, cc @douglas-reid . |
|
if the tests are running with the old rules, then the flag that was being set for those tests is no longer being set. This PR made the transition, iirc: #6378 |
|
/retest prow/istio-presubmit.sh |
|
@frankbu can you please approve? All the files there are needed, the destination-rule-all-mtls.yaml contains a different policy. |
|
/retest all |
|
/lgtm |
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andraxylia, rshriram The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bookinfo changes to ensure when we create and delete VirtualServices via istioctl replace we do not delete the DestinationRules and cause traffic loss.
Associated istio.io change to come.