Skip to content

Replace v1 e2e_mixer make target with v2#6378

Merged
istio-testing merged 3 commits intoistio:masterfrom
ostromart:fix_mixer_prow
Jun 19, 2018
Merged

Replace v1 e2e_mixer make target with v2#6378
istio-testing merged 3 commits intoistio:masterfrom
ostromart:fix_mixer_prow

Conversation

@ostromart
Copy link
Copy Markdown
Contributor

No description provided.

@ostromart ostromart requested a review from hklai June 18, 2018 23:11
@ostromart
Copy link
Copy Markdown
Contributor Author

Fixes #6372.

@ostromart
Copy link
Copy Markdown
Contributor Author

/retest

@hklai
Copy link
Copy Markdown
Contributor

hklai commented Jun 18, 2018

/test e2e-suite-rbac-no_auth
/test e2e-suite-rbac-auth
/test e2e-cluster_wide-auth

1 similar comment
@hklai
Copy link
Copy Markdown
Contributor

hklai commented Jun 18, 2018

/test e2e-suite-rbac-no_auth
/test e2e-suite-rbac-auth
/test e2e-cluster_wide-auth

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 19, 2018

Codecov Report

Merging #6378 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6378    +/-   ##
=======================================
- Coverage      68%     68%   -<1%     
=======================================
  Files         351     351            
  Lines       30635   30619    -16     
=======================================
- Hits        20745   20705    -40     
- Misses       9041    9072    +31     
+ Partials      849     842     -7
Impacted Files Coverage Δ
mixer/adapter/stackdriver/stackdriver.go 50% <0%> (-13%) ⬇️
mixer/adapter/cloudwatch/cloudwatch.go 58% <0%> (-9%) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 61% <0%> (-6%) ⬇️
mixer/adapter/stackdriver/log/log.go 65% <0%> (-3%) ⬇️
mixer/adapter/rbac/rbac.go 11% <0%> (-3%) ⬇️
mixer/adapter/bypass/util.go 8% <0%> (-3%) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (-2%) ⬇️
mixer/adapter/prometheus/server.go 97% <0%> (-1%) ⬇️
mixer/adapter/list/regexList.go 100% <0%> (ø) ⬆️
mixer/pkg/status/status.go 100% <0%> (ø) ⬆️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c90bc0...9375ac4. Read the comment docs.

@hklai
Copy link
Copy Markdown
Contributor

hklai commented Jun 19, 2018

/test e2e-suite-rbac-no_auth
/test e2e-suite-rbac-auth
/test e2e-cluster_wide-auth

tests/istio.mk Outdated

e2e_mixer_run: out_dir
go test -v -timeout 20m ./tests/e2e/tests/mixer -args ${E2E_ARGS} ${EXTRA_E2E_ARGS}
e2e_mixer_run: out_dir generate_yaml-envoyv2_transition_loadbalancer_ingressgateway
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generate_yaml-envoyv2_transition_loadbalancer_ingressgateway is not needed here since it is already done in "e2e_mixer"

Copy link
Copy Markdown
Contributor

@hklai hklai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hklai, ostromart

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit f588e41 into istio:master Jun 19, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jun 19, 2018

@ostromart: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
prow/e2e-suite-rbac-auth.sh 171bd24 link /test e2e-suite-rbac-auth
prow/e2e-cluster_wide-auth.sh 171bd24 link /test e2e-cluster_wide-auth
prow/e2e-suite-rbac-no_auth.sh 171bd24 link /test e2e-suite-rbac-no_auth
prow/istio-pilot-e2e.sh 9375ac4 link /test istio-pilot-e2e
prow/e2e-bookInfoTests.sh 9375ac4 link /test e2e-bookInfo
Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants