Skip to content

Remove the Envoy v1 implementation#6865

Merged
rshriram merged 1 commit intoistio:release-1.0from
ijsnellf:remove_v1_impl
Jul 5, 2018
Merged

Remove the Envoy v1 implementation#6865
rshriram merged 1 commit intoistio:release-1.0from
ijsnellf:remove_v1_impl

Conversation

@ijsnellf
Copy link
Copy Markdown
Contributor

@ijsnellf ijsnellf commented Jul 5, 2018

Removes unused files.

#6049

@istio-testing istio-testing requested review from ayj and costinm July 5, 2018 18:31
@ijsnellf ijsnellf changed the base branch from master to release-1.0 July 5, 2018 19:42
@ijsnellf ijsnellf changed the base branch from release-1.0 to master July 5, 2018 19:43
@costinm
Copy link
Copy Markdown
Contributor

costinm commented Jul 5, 2018

/lgtm
/approve

Not sure if this needs to be backported to release-1.0 - and it may be good to stop making changes to master for next 2 weeks, to have a smooth merge back fro rel1.0

@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 5, 2018

/hold

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Jul 5, 2018
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 5, 2018

Please backport to 1.0.. Else, we will have a painful merge

@istio-testing istio-testing removed the lgtm label Jul 5, 2018
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 5, 2018

Codecov Report

Merging #6865 into master will decrease coverage by 1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #6865    +/-   ##
=======================================
- Coverage      71%     71%   -<1%     
=======================================
  Files         369     369            
  Lines       31907   31958    +51     
=======================================
+ Hits        22420   22440    +20     
- Misses       8574    8586    +12     
- Partials      913     932    +19
Impacted Files Coverage Δ
galley/pkg/mcp/client/client.go 71% <0%> (-6%) ⬇️
galley/pkg/mcp/server/server.go 82% <0%> (-4%) ⬇️
mixer/adapter/cloudwatch/handler.go 87% <0%> (-4%) ⬇️
pilot/pkg/serviceregistry/kube/queue.go 86% <0%> (-3%) ⬇️
galley/pkg/kube/listener.go 93% <0%> (-2%) ⬇️
mixer/adapter/kubernetesenv/cache.go 94% <0%> (-1%) ⬇️
mixer/adapter/opa/opa.go 79% <0%> (ø) ⬇️
mixer/adapter/circonus/circonus.go 71% <0%> (ø) ⬇️
pilot/pkg/serviceregistry/kube/controller.go 69% <0%> (ø) ⬇️
mixer/pkg/protobuf/yaml/pool.go 100% <0%> (ø) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 865e90e...629ad7c. Read the comment docs.

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Jul 5, 2018
@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 5, 2018

@ijsnellf: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link
Copy Markdown
Collaborator

googlebot commented Jul 5, 2018

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes labels Jul 5, 2018
@ijsnellf ijsnellf changed the base branch from master to release-1.0 July 5, 2018 20:34
@ijsnellf ijsnellf added cla: human-approved and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. needs-rebase Indicates a PR needs to be rebased before being merged labels Jul 5, 2018
@rshriram
Copy link
Copy Markdown
Member

rshriram commented Jul 5, 2018

/lgtm

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 5, 2018

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: costinm, ijsnellf, rshriram

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rshriram rshriram merged commit da8cbf8 into istio:release-1.0 Jul 5, 2018
@ijsnellf ijsnellf deleted the remove_v1_impl branch July 6, 2018 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregHanson GregHanson Awaiting requested review from GregHanson

@ostromart ostromart Awaiting requested review from ostromart

@ayj ayj Awaiting requested review from ayj

@costinm costinm Awaiting requested review from costinm

1 more reviewer

@rshriram rshriram rshriram approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@costinm costinm

@rshriram rshriram

Labels

do-not-merge/hold Block automatic merging of a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ijsnellf @costinm @rshriram @istio-testing @googlebot