@Dhruwang is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Thank you for following the naming conventions for pull request titles! 🙏

The changes in this PR seem to be well implemented. The addition of the isCodeAction variable to handle different action types is a good approach. However, there are a few suggestions to improve the code:

1. The isCodeAction variable is used multiple times in the code. It would be better to use useMemo to avoid unnecessary re-computations.

const isCodeAction = useMemo(() => actionClass.type === "code", [actionClass.type]);

2. The onSubmit function is quite large and does a lot of things. It would be better to split it into smaller functions for better readability and maintainability. For example, you could create a separate function to handle the validation logic.

3. The error messages thrown in the onSubmit function could be more specific. For example, instead of "Please select at least one selector", you could specify which selectors are required.

4. The filterNoCodeConfig function could be simplified by using a map of the state variables and the corresponding keys in the noCodeConfig object. This would make the function more scalable if more selectors are added in the future.

const filterNoCodeConfig = (noCodeConfig: TActionClassNoCodeConfig): TActionClassNoCodeConfig => {
  const selectors = { isPageUrl: 'pageUrl', isInnerHtml: 'innerHtml', isCssSelector: 'cssSelector' };
  const filteredNoCodeConfig: TActionClassNoCodeConfig = {};

  Object.entries(selectors).forEach(([stateVar, key]) => {
    if (this[stateVar] && noCodeConfig[key]?.value) {
      filteredNoCodeConfig[key] = { value: noCodeConfig[key].value };
    }
  });

  return filteredNoCodeConfig;
};

5. The onSubmit function could be simplified by using a ternary operator to set the type property of the updatedData object.

const updatedData: TActionClassInput = {
  ...data,
  environmentId,
  noCodeConfig: filteredNoCodeConfig,
  type: isCodeAction ? "code" : "noCode",
} as TActionClassInput;

6. The handleDeleteAction function could be improved by adding a specific error message in the catch block. This would help with debugging if an error occurs.

catch (error) {
  toast.error(`Failed to delete action: ${error.message}`);
}

The latest updates on your projects. Learn more about Vercel for Git ↗︎