Skip to content

Conversation

@rohan9896
Copy link
Contributor

What does this PR do?

Fixes # (issue)
#1501 Fixes the bug of not resetting the long URL field after closing the Modal.

https://www.loom.com/share/878810dfb8c14c04a3b820ba5b60b78e?sid=6fa377e2-33e1-40a5-9e31-5f90f47c3416

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 29, 2023

Someone is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@review-agent-prime
Copy link
Contributor

The changes in this PR look good overall. However, I have a few suggestions to improve the code:

  1. It seems like you're using the reset function from useForm to reset the form. This is a good practice, but it would be better to specify which fields you want to reset. This way, if you add more fields to the form in the future, you won't accidentally reset them. Here's how you can do it:
reset({ url: "" }); // resets only the url field
  1. The createShortUrlAction function is used without any error handling. It would be a good idea to wrap this function call in a try-catch block to handle any potential errors that might occur during the URL shortening process. Here's an example:
try {
  const shortUrl = await createShortUrlAction(data.url.trim());
  setShortUrl(shortUrl);
} catch (error) {
  console.error("Failed to create short URL", error);
}
  1. The copyShortUrlToClipboard function is used without checking if the shortUrl is empty or not. It would be better to add a condition to check if the shortUrl is not empty before copying it to the clipboard. Here's how you can do it:
const copyShortUrlToClipboard = () => {
  if (shortUrl) {
    navigator.clipboard.writeText(shortUrl);
    toast.success("URL copied to clipboard!");
  } else {
    toast.error("No URL to copy!");
  }
};

Please consider these suggestions and let me know if you have any questions.

@raghavnagar7
Copy link

The changes in this PR look good overall. However, I have a few suggestions to improve the code:

It seems like you're using the reset function from useForm to reset the form. This is a good practice, but it would be better to specify which fields you want to reset. This way, if you add more fields to the form in the future, you won't accidentally reset them. Here's how you can do it:
reset({ url: "" }); // resets only the url field
The createShortUrlAction function is used without any error handling. It would be a good idea to wrap this function call in a try-catch block to handle any potential errors that might occur during the URL shortening process. Here's an example:
try {
const shortUrl = await createShortUrlAction(data.url.trim());
setShortUrl(shortUrl);
} catch (error) {
console.error("Failed to create short URL", error);
}
The copyShortUrlToClipboard function is used without checking if the shortUrl is empty or not. It would be better to add a condition to check if the shortUrl is not empty before copying it to the clipboard. Here's how you can do it:
const copyShortUrlToClipboard = () => {
if (shortUrl) {
navigator.clipboard.writeText(shortUrl);
toast.success("URL copied to clipboard!");
} else {
toast.error("No URL to copy!");
}
};
try {
const shortUrl = await createShortUrlAction(data.url.trim());
setShortUrl(shortUrl);
} catch (error) {
console.error("Failed to create short URL", error);
}
Please consider these suggestions and let me know if you have any questions.

Copy link
Member

@Dhruwang Dhruwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rohan9896 for the fix, works well 😊💪

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 3:48am
formbricks-com ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2023 3:48am

@Dhruwang Dhruwang added bug Something isn't working hacktoberfest complete these issues to gather points for Hacktoberfest formtribe-2023 labels Oct 30, 2023
@mattinannt mattinannt added this pull request to the merge queue Oct 30, 2023
Merged via the queue into formbricks:main with commit 1d5b832 Oct 30, 2023
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Oct 30, 2023
* main: (28 commits)
  chore: Add Table of Contents to README (formbricks#1427)
  fix: account deletion failing issue (formbricks#1509)
  fix: remove welcome card from email preview (formbricks#1495)
  fix(bug): default role implemented (formbricks#1524)
  fix: changing description of Code Action (formbricks#1522)
  refactor: Migrate activity service (formbricks#1471)
  fix: Error in Docs navigation formbricks#1518 (formbricks#1521)
  feat: dynamic title and description (formbricks#1459)
  fix: Spelling Errors (formbricks#1517)
  fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498)
  fix: long url not getting reset after closing modal (formbricks#1502)
  fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506)
  fix: zod pin validation failing (formbricks#1507)
  fix: Error message on Login not shown  (formbricks#1508)
  fix: downgrade nextjs to fix error with react email (formbricks#1516)
  chore: downgrade next version in formbricks-com (formbricks#1513)
  feat: picture selection question (formbricks#1388)
  feat: formtribe leaderboard update as per today (formbricks#1505)
  fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435)
  fix: Disabling Welcome Card leads buggy preview (formbricks#1320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working hacktoberfest complete these issues to gather points for Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants