Skip to content

Conversation

@ShubhamPalriwala
Copy link
Contributor

What does this PR do?

Updates Formtribe Leaderboard as per Notion as of now

@vercel
Copy link

vercel bot commented Oct 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Oct 29, 2023 7:37pm
formbricks-com ⬜️ Ignored (Inspect) Oct 29, 2023 7:37pm

@github-actions
Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@review-agent-prime
Copy link
Contributor

The PR seems to be updating the points for various users and adding new users to the list. The changes look fine, but there are a couple of things that could be improved:

  1. It seems like the points property is a string. It would be more appropriate to use a number for this property. This would allow for easier calculations in the future if needed.

  2. There are two new users added ("Kurayami", "Sandy-1711") without points. Please make sure to add points for these users if it was intended for them to have points.

Here are the suggested changes:

{
  name: "Aditya Deshlahre",
- points: "1370",
+ points: 1370,
  link: "https://github.com/adityadeshlahre",
},
{
  name: "thanmaisai",
- points: "1900",
+ points: 1900,
},
{
  name: "Anjaneya Gupta",
- points: "2150",
+ points: 2150,
},
{
  name: "Bilal Mirza",
- points: "1395",
+ points: 1395,
},
{
  name: "Sachin Mittal",
- points: "450",
+ points: 450,
},
{
  name: "Shyam Raghu",
- points: "400",
+ points: 400,
},
{
  name: "Harshit Vashisht",
- points: "200",
+ points: 200,
},
{
  name: "JiyaGupta-cs",
- points: "50",
+ points: 50,
},
{
  name: "Kurayami",
+ points: 0, // or any other default value
},
{
  name: "Sandy-1711",
- points: "50",
+ points: 50,
},

Please consider these changes to improve the code quality and maintainability.

@ShubhamPalriwala ShubhamPalriwala added this pull request to the merge queue Oct 29, 2023
Merged via the queue into main with commit d3356cb Oct 29, 2023
@ShubhamPalriwala ShubhamPalriwala deleted the shubham/formtribe-leaderboard-update-29-10 branch October 29, 2023 19:50
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Oct 30, 2023
* main: (28 commits)
  chore: Add Table of Contents to README (formbricks#1427)
  fix: account deletion failing issue (formbricks#1509)
  fix: remove welcome card from email preview (formbricks#1495)
  fix(bug): default role implemented (formbricks#1524)
  fix: changing description of Code Action (formbricks#1522)
  refactor: Migrate activity service (formbricks#1471)
  fix: Error in Docs navigation formbricks#1518 (formbricks#1521)
  feat: dynamic title and description (formbricks#1459)
  fix: Spelling Errors (formbricks#1517)
  fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498)
  fix: long url not getting reset after closing modal (formbricks#1502)
  fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506)
  fix: zod pin validation failing (formbricks#1507)
  fix: Error message on Login not shown  (formbricks#1508)
  fix: downgrade nextjs to fix error with react email (formbricks#1516)
  chore: downgrade next version in formbricks-com (formbricks#1513)
  feat: picture selection question (formbricks#1388)
  feat: formtribe leaderboard update as per today (formbricks#1505)
  fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435)
  fix: Disabling Welcome Card leads buggy preview (formbricks#1320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants