@HarshitVashisht11 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

Thank you for following the naming conventions for pull request titles! 🙏

This PR looks fine with some additional conditions for the QuestionConditional component. However, it seems like there's a possible assumption that could lead to an error in some circumstances.

You're assuming survey?.questions[0] would always exist when questionId === "start" && !survey.welcomeCard.enabled is true and you're directly passing it as props to the QuestionConditional component. If for some reason it doesn't exist, this could potentially lead to runtime errors. To handle that, you might want to consider adding a null check before using it.

) : questionId === "start" && !survey.welcomeCard.enabled && survey?.questions[0] ? (
    <QuestionConditional
      question={survey.questions[0]}
      value={responseData[survey.questions[0]?.id]}
      onChange={onChange}
      onSubmit={onSubmit}
      onBack={onBack}
      isFirstQuestion={
        // if prefillResponseData is provided, check if we're on the first "real" question
        history && prefillResponseData
          ? history[history.length - 1] === survey.questions[0].id
          : true
      }
      isLastQuestion={0 === survey.questions.length - 1}
      brandColor={brandColor}
    />
) : survey.questions.length > 0 ? (
  survey.questions.map(
    (question, idx) => {/* existing logic */}
) : null

In the code above, before rendering QuestionConditional component, I've added an additional check for survey?.questions[0]. If it doesn't exist, fallback mechanism is to execute the existing logic of the original else case if survey question length is greater than zero, else return null. This code ensures checks are performed and won't lead to a potential crash due to missing survey question.

Hey @HarshitVashisht11 , this looks good 😊🥳

However it would be better if we don't repeat the code for rendering QuestionConditional twice
Can you please find a generic solution for it ?😊

Because we also want to use this fix for thank you card and as per this approach we have to create one more render for QuestionConditional

And can you also create similar fix for thank you card (if disabled, show last question)

Thank you ! 🚀

sure i will try

Hey @HarshitVashisht11 😊 , is it ready for review ?
Because I tested the functionality after pulling the latest changes and it is not working :(
Converting this to draft for now, please mark it as ready for review once its completed 😊

Hi @Dhruwang can tell how to remove thankyou card because i am not able to find option of removing thank you card in the website

Actually thank you card is mandatory for link surveys but optional for in-app survey (web app), so you will see toggle for it only for in-app surveys

Hope this helps
If you have any other question feel free to reach out 😊

@Dhruwang i can't understand when thank you card is disabled so what will it display when you click on finish

It should display last question

But on last question if someone clicked on finish so why will it show last question

For link surveys, thank you card is compulsory to after last questions respondent sees the thank you card
But for web app (in-app) surveys, can you create this behaviour 😊

@Dhruwang is these changes are good ?

@HarshitVashisht11 The Welcome Card behaviour is good, this works :) People can check out the card but the Preview doesnt break!

On the Thank You card, its not good:

1. When the Thank You card is disabled, after the last question the web app survey has to go away. In the Survey Editor we have it slide out to the right, reset to the first question and slide back in from the right to indicate that the survey was over.
2. The Thank You Card should behave exactly like the Welcome Card: When its disabled and people click on it, it should still open but the Preview should not change. You've built it already for the Welcome Card, just apply it to the Thank You card as well.

Thanks!! 🙏

I have made the following changes

@Dhruwang please review my changes

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Thank you @HarshitVashisht11 for the changes, works good 😊🚀
I just pushed a minor fix for welcome card 😊

Hi @Dhruwang Thank you for reviewing my PR, I'm excited to know when my PR might get merged , as hacktoberfest is about to end and I still left 1 more PR.

Works well, sorry for the delay and thanks! :)