-
Notifications
You must be signed in to change notification settings - Fork 2.1k
refactor: Migrate activity service #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Ignored Deployments
|
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
The changes in this PR are generally well done. However, there are a few areas that could be improved:
const ITEMS_PER_PAGE = 5;
export default function ActivityFeed({ actions, sortByDate, environment }: ActivityFeedProps) {
// ...
}
export const ActivityItemIcon = ({ actionItem }: { actionItem: TAction }) => (
<div className="h-12 w-12 rounded-full bg-white p-3 text-slate-500 duration-100 ease-in-out group-hover:scale-110 group-hover:text-slate-600">
{actionItem.actionClass && (
<div>
{actionItem.actionClass.type === "code" && <CodeBracketIcon />}
{actionItem.actionClass.type === "noCode" && <CursorArrowRaysIcon />}
{actionItem.actionClass.type === "automatic" && <SparklesIcon />}
</div>
)}
</div>
);
export const ActivityItemPopover = ({
actionItem,
children,
}: {
actionItem: TAction;
children: React.ReactNode;
}) => {
return (
<Popover>
<PopoverTrigger className="group">{children}</PopoverTrigger>
<PopoverContent className="bg-white">
<div>
{actionItem.actionClass && (
<div>
<Label className="font-normal text-slate-400">Action Label</Label>
<p className=" mb-2 text-sm font-medium text-slate-900">{actionItem.actionClass.name}</p>
<Label className="font-normal text-slate-400">Action Description</Label>
<p className="text-sm font-medium text-slate-900">{actionItem.actionClass.description}</p>
<Label className="font-normal text-slate-400">Action Type</Label>
<p className="text-sm font-medium text-slate-900">{actionItem.actionClass.type}</p>
</div>
)}
</div>
</PopoverContent>
</Popover>
);
};
actionsPrisma.forEach((action) => {
actions.push({
id: action.id,
createdAt: action.createdAt,
sessionId: action.sessionId,
properties: action.properties,
actionClass: action.eventClass || null,
});
});
const actionItemList: TAction[] = [
{
id: "demoId1",
// ...
},
{
id: "demoId2",
// ...
},
]; |
mattinannt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏👍
I changed the behaviour a bit since a problem came up where users might have thousands of actions inside their account. To solve this I'm now getting the first page from the backend and to make displays even easier, I only show the last 10 actions here and fade them out.
* main: (28 commits) chore: Add Table of Contents to README (formbricks#1427) fix: account deletion failing issue (formbricks#1509) fix: remove welcome card from email preview (formbricks#1495) fix(bug): default role implemented (formbricks#1524) fix: changing description of Code Action (formbricks#1522) refactor: Migrate activity service (formbricks#1471) fix: Error in Docs navigation formbricks#1518 (formbricks#1521) feat: dynamic title and description (formbricks#1459) fix: Spelling Errors (formbricks#1517) fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498) fix: long url not getting reset after closing modal (formbricks#1502) fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506) fix: zod pin validation failing (formbricks#1507) fix: Error message on Login not shown (formbricks#1508) fix: downgrade nextjs to fix error with react email (formbricks#1516) chore: downgrade next version in formbricks-com (formbricks#1513) feat: picture selection question (formbricks#1388) feat: formtribe leaderboard update as per today (formbricks#1505) fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435) fix: Disabling Welcome Card leads buggy preview (formbricks#1320) ...
What does this PR do?
Fixes FOR-1445
getActionsByPersonIdScreen-Recording-2023-10-26-at-10.19.52.PM.mp4
Type of change
Checklist
Required
pnpm buildconsole.logsgit pull origin mainAppreciated