Skip to content

feat: dynamic title and description #1459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pandeymangg merged 4 commits into from
Oct 30, 2023
Merged

feat: dynamic title and description #1459

pandeymangg merged 4 commits into from
Oct 30, 2023

Conversation

@vikaspatil0021
Copy link
Contributor

@vikaspatil0021 vikaspatil0021 commented Oct 25, 2023

Fixes #1428
dynamic title and description for each page

Screenshot 2023-10-25 112708
Screenshot 2023-10-25 112727
Screenshot 2023-10-25 112757

@vercel
Copy link

vercel bot commented Oct 25, 2023

@vikaspatil0021 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added enhancement New feature or request formtribe-2023 good first issue Good for newcomers hacktoberfest complete these issues to gather points for Hacktoberfest labels Oct 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 25, 2023 •
edited
Loading

Thank you for following the naming conventions for pull request titles! 🙏

@review-agent-prime
Copy link
Contributor

review-agent-prime bot commented Oct 25, 2023

The changes in this PR mainly involve renaming the meta object to metadata and updating the title property in each file. This seems to be a straightforward change and doesn't appear to introduce any issues. However, it would be helpful to understand the reason behind this change. Is there a specific issue or improvement that this change is addressing?

One suggestion I have is to ensure that the new metadata object is correctly used wherever the meta object was previously referenced. This might be in components that consume these metadata or in tests. If these references are not updated, it could potentially break the functionality or the tests.

For example, if there is a component that uses the meta object, it should be updated to use metadata:

- const { title, description } = meta;
+ const { title, description } = metadata;

Please ensure that all references to the meta object are updated to metadata to avoid any potential issues.

@SamsShow
Copy link

SamsShow commented Oct 26, 2023

I would like to work on this issue

@Paulie-Aditya
Copy link

Paulie-Aditya commented Oct 28, 2023

could I get assigned to this?

@raghavnagar7
Copy link

raghavnagar7 commented Oct 29, 2023

The changes in this PR mainly involve renaming the meta object to metadata and updating the title property in each file. This seems to be a straightforward change and doesn't appear to introduce any issues. However, it would be helpful to understand the reason behind this change. Is there a specific issue or improvement that this change is addressing?

One suggestion I have is to ensure that the new metadata object is correctly used wherever the meta object was previously referenced. This might be in components that consume these metadata or in tests. If these references are not updated, it could potentially break the functionality or the tests.

For example, if there is a component that uses the meta object, it should be updated to use metadata:

  • const { title, description } = meta;
  • const { title, description } = metadata;
    Please ensure that all references to the meta object are updated to metadata to avoid any potential issues.

@pandeymangg pandeymangg enabled auto-merge October 30, 2023 11:36
@pandeymangg pandeymangg added this pull request to the merge queue Oct 30, 2023
Merged via the queue into formbricks:main with commit be018e8 Oct 30, 2023
@mattinannt mattinannt mentioned this pull request Oct 30, 2023
Closed
18 tasks
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Oct 30, 2023
@kevinkong91
Merge branch 'main' into dev
3f28fac 
* main: (28 commits)
  chore: Add Table of Contents to README (formbricks#1427)
  fix: account deletion failing issue (formbricks#1509)
  fix: remove welcome card from email preview (formbricks#1495)
  fix(bug): default role implemented (formbricks#1524)
  fix: changing description of Code Action (formbricks#1522)
  refactor: Migrate activity service (formbricks#1471)
  fix: Error in Docs navigation formbricks#1518 (formbricks#1521)
  feat: dynamic title and description (formbricks#1459)
  fix: Spelling Errors (formbricks#1517)
  fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498)
  fix: long url not getting reset after closing modal (formbricks#1502)
  fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506)
  fix: zod pin validation failing (formbricks#1507)
  fix: Error message on Login not shown  (formbricks#1508)
  fix: downgrade nextjs to fix error with react email (formbricks#1516)
  chore: downgrade next version in formbricks-com (formbricks#1513)
  feat: picture selection question (formbricks#1388)
  feat: formtribe leaderboard update as per today (formbricks#1505)
  fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435)
  fix: Disabling Welcome Card leads buggy preview (formbricks#1320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request ❗️ .env changes good first issue Good for newcomers hacktoberfest complete these issues to gather points for Hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE][FormTribe 🔥][150 Points] Dynamic metadata for new Docs

5 participants

@vikaspatil0021 @SamsShow @Paulie-Aditya @raghavnagar7 @pandeymangg