fix: added scrollbar whenever overflowed in the settings/profile page #1498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the formbricks Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
Thank you for following the naming conventions for pull request titles! 🙏 |
Contributor
|
The changes in the PR look good, but there's a small improvement that can be made. In the new line added, you've used Here's the suggested change: - <div className="fixed hidden h-full overflow-scroll bg-white py-2 pl-4 pr-10 md:block">
+ <div className="fixed hidden h-full overflow-auto bg-white py-2 pl-4 pr-10 md:block">This will make the UI cleaner when the scrollbar is not needed. |
…flow-scroll-for-sidenav-profile
mattinannt
approved these changes
Oct 30, 2023
Member
mattinannt
left a comment
There was a problem hiding this comment.
@abhinaisai2002 thanks a lot for the fix :-)
kevinkong91
added a commit
to kevinkong91/formbricks
that referenced
this pull request
Oct 30, 2023
* main: (28 commits) chore: Add Table of Contents to README (formbricks#1427) fix: account deletion failing issue (formbricks#1509) fix: remove welcome card from email preview (formbricks#1495) fix(bug): default role implemented (formbricks#1524) fix: changing description of Code Action (formbricks#1522) refactor: Migrate activity service (formbricks#1471) fix: Error in Docs navigation formbricks#1518 (formbricks#1521) feat: dynamic title and description (formbricks#1459) fix: Spelling Errors (formbricks#1517) fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498) fix: long url not getting reset after closing modal (formbricks#1502) fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506) fix: zod pin validation failing (formbricks#1507) fix: Error message on Login not shown (formbricks#1508) fix: downgrade nextjs to fix error with react email (formbricks#1516) chore: downgrade next version in formbricks-com (formbricks#1513) feat: picture selection question (formbricks#1388) feat: formtribe leaderboard update as per today (formbricks#1505) fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435) fix: Disabling Welcome Card leads buggy preview (formbricks#1320) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The sidenav is not scrollable when it is overflowed.
I fixed this issue.
Fixes #1476
Type of change
How should this be tested?
Checklist
Required
pnpm buildgit pull origin mainconsole.logsAppreciated