-
Notifications
You must be signed in to change notification settings - Fork 2.1k
fix: downgrade nextjs to fix error with react email #1516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
|
Thank you for following the naming conventions for pull request titles! 🙏 |
|
Overall, the changes in this PR look good. However, there are a few points that could be improved:
Here are the code suggestions:
-import { NextRequest } from "next/server";
-import { ImageResponse } from "next/og";
+import { ImageResponse, NextRequest } from "next/server";
- const ogImgURL = `/api/v1/og?brandColor=${brandColor}&name=${surveyName}`;
+ const ogImgURL = `${WEBAPP_URL}/api/v1/og?brandColor=${brandColor}&name=${surveyName}`;
...
- url: `/s/${survey.id}`,
+ url: `${WEBAPP_URL}/${survey.id}`,
experimental: {
- serverActions: true,
+ // serverActions: true,
},
Without the actual code, it's hard to provide more specific feedback or suggestions. Please provide the actual code changes for a more detailed review. |
* main: (28 commits) chore: Add Table of Contents to README (formbricks#1427) fix: account deletion failing issue (formbricks#1509) fix: remove welcome card from email preview (formbricks#1495) fix(bug): default role implemented (formbricks#1524) fix: changing description of Code Action (formbricks#1522) refactor: Migrate activity service (formbricks#1471) fix: Error in Docs navigation formbricks#1518 (formbricks#1521) feat: dynamic title and description (formbricks#1459) fix: Spelling Errors (formbricks#1517) fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498) fix: long url not getting reset after closing modal (formbricks#1502) fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506) fix: zod pin validation failing (formbricks#1507) fix: Error message on Login not shown (formbricks#1508) fix: downgrade nextjs to fix error with react email (formbricks#1516) chore: downgrade next version in formbricks-com (formbricks#1513) feat: picture selection question (formbricks#1388) feat: formtribe leaderboard update as per today (formbricks#1505) fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435) fix: Disabling Welcome Card leads buggy preview (formbricks#1320) ...
What does this PR do?
fix: downgrade nextjs to fix error with react email
Type of change