Skip to content

chore: downgrade next version in formbricks-com #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pandeymangg merged 1 commit into from
Oct 30, 2023
Merged

chore: downgrade next version in formbricks-com #1513

pandeymangg merged 1 commit into from
Oct 30, 2023

Conversation

@pandeymangg
Copy link
Contributor

@pandeymangg pandeymangg commented Oct 30, 2023

What does this PR do?

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
formbricks-cloud ⬜️ Ignored (Inspect) Oct 30, 2023 8:34am
formbricks-com ⬜️ Ignored (Inspect) Oct 30, 2023 8:34am

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2023

Thank you for following the naming conventions for pull request titles! 🙏

@review-agent-prime
Copy link
Contributor

review-agent-prime bot commented Oct 30, 2023

The PR shows a downgrade of the "next" package from version "13.5.5" to "13.4.19". If this downgrade is intentional, please ensure that it doesn't break any existing functionality that relies on features or fixes introduced in the newer version. If it's not intentional, I would suggest keeping the package up-to-date. Here's the suggested change:

-    "next": "13.4.19",
+    "next": "13.5.5",

Please make sure to test the application thoroughly after making this change.
The PR seems to be updating the versions of various dependencies in the pnpm-lock.yaml file. Here are a few suggestions:

  1. Ensure that the updated versions of the dependencies are compatible with the rest of the codebase. This can be done by running all the tests after the dependencies have been updated.

  2. It's a good practice to check the changelogs of the updated dependencies to understand what has changed. This can help identify potential issues that could arise from the update.

  3. Consider using a tool like Dependabot to automate dependency updates. This can help keep your dependencies up-to-date and reduce the manual work of updating them.

  4. Make sure to thoroughly test the application after updating the dependencies to ensure everything still works as expected.

  5. It's a good practice to update dependencies in small batches. This makes it easier to identify which update caused a problem if one arises.

  6. If a dependency is not being used in the project, consider removing it to reduce the complexity and potential security vulnerabilities of your project.

  7. If the project is using a continuous integration (CI) service, make sure that the CI build passes after the dependencies have been updated.

@pandeymangg pandeymangg enabled auto-merge October 30, 2023 08:41
@pandeymangg pandeymangg added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit dcefbc9 Oct 30, 2023
@pandeymangg pandeymangg deleted the hotfix/docs-fix branch October 30, 2023 08:50
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Oct 30, 2023
@kevinkong91
Merge branch 'main' into dev
3f28fac 
* main: (28 commits)
  chore: Add Table of Contents to README (formbricks#1427)
  fix: account deletion failing issue (formbricks#1509)
  fix: remove welcome card from email preview (formbricks#1495)
  fix(bug): default role implemented (formbricks#1524)
  fix: changing description of Code Action (formbricks#1522)
  refactor: Migrate activity service (formbricks#1471)
  fix: Error in Docs navigation formbricks#1518 (formbricks#1521)
  feat: dynamic title and description (formbricks#1459)
  fix: Spelling Errors (formbricks#1517)
  fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498)
  fix: long url not getting reset after closing modal (formbricks#1502)
  fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506)
  fix: zod pin validation failing (formbricks#1507)
  fix: Error message on Login not shown  (formbricks#1508)
  fix: downgrade nextjs to fix error with react email (formbricks#1516)
  chore: downgrade next version in formbricks-com (formbricks#1513)
  feat: picture selection question (formbricks#1388)
  feat: formtribe leaderboard update as per today (formbricks#1505)
  fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435)
  fix: Disabling Welcome Card leads buggy preview (formbricks#1320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pandeymangg