Skip to content

Conversation

@bilalmirza74
Copy link
Contributor

What does this PR do?

Fixes # (issue)

some of them are:

multipe => multiple
specfic => specific
simplte => simple
Worskpace => workspace
Paylod => Payload

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • Enhancement (small improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change adds a new database migration
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

Required

  • Filled out the "How to test" section in this PR
  • Read How we Code at Formbricks
  • Self-reviewed my own code
  • Commented on my code in hard-to-understand bits
  • Ran pnpm build
  • Checked for warnings, there are none
  • Removed all console.logs
  • Merged the latest changes from main onto my branch with git pull origin main
  • My changes don't cause any responsiveness issues
  • First PR at Formbricks? Please sign the CLA! Without it we wont be able to merge it 🙏

Appreciated

  • If a UI change was made: Added a screen recording or screenshots to this PR
  • Updated the Formbricks Docs if changes were necessary

@vercel
Copy link

vercel bot commented Oct 30, 2023

@bilalmirza74 is attempting to deploy a commit to the formbricks Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

Thank you for following the naming conventions for pull request titles! 🙏

@review-agent-prime
Copy link
Contributor

The changes in the PR mainly consist of typo corrections and minor grammatical adjustments. These changes are necessary for improving the readability and understanding of the documentation. Here are a few suggestions:

  1. In the file apps/formbricks-com/app/docs/api/management/webhooks/page.mdx, the typo correction from "Paylod" to "Payload" is appropriate and improves the clarity of the sentence.

  2. In the file apps/formbricks-com/app/docs/best-practices/cancel-subscription/page.mdx, the correction from "you offering" to "your offering" is grammatically correct and improves the sentence's readability.

  3. In the file apps/formbricks-com/app/docs/best-practices/docs-feedback/page.mdx, the addition of "to" in the sentence "you need update the" improves the sentence's grammatical correctness.

  4. In the file apps/formbricks-com/app/docs/best-practices/feature-chaser/page.mdx, the correction from "specfic" to "specific" is appropriate and improves the sentence's readability.

  5. In the file apps/formbricks-com/app/docs/best-practices/interview-prompt/page.mdx, the addition of "it" in the sentence "you’ll likely want to display on a page visit" improves the sentence's grammatical correctness.

  6. In the file apps/formbricks-com/app/docs/contributing/gitpod/page.mdx, the correction from "Worskpace" to "workspace" is appropriate and improves the clarity of the sentence.

  7. In the file apps/formbricks-com/app/docs/getting-started/framework-guides/page.mdx, the correction from "multipe" to "multiple" is appropriate and improves the sentence's readability.

  8. In the file apps/formbricks-com/app/docs/link-surveys/single-use-links/page.mdx, the correction from "simplte" to "simple" is appropriate and improves the clarity of the sentence.

Overall, the changes made in this PR are beneficial and improve the quality of the documentation.

Copy link
Member

@mattinannt mattinannt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bilalmirza74 thanks a lot for the fixes :-)

@mattinannt mattinannt enabled auto-merge October 30, 2023 11:06
@mattinannt mattinannt added this pull request to the merge queue Oct 30, 2023
Merged via the queue into formbricks:main with commit 393238e Oct 30, 2023
kevinkong91 added a commit to kevinkong91/formbricks that referenced this pull request Oct 30, 2023
* main: (28 commits)
  chore: Add Table of Contents to README (formbricks#1427)
  fix: account deletion failing issue (formbricks#1509)
  fix: remove welcome card from email preview (formbricks#1495)
  fix(bug): default role implemented (formbricks#1524)
  fix: changing description of Code Action (formbricks#1522)
  refactor: Migrate activity service (formbricks#1471)
  fix: Error in Docs navigation formbricks#1518 (formbricks#1521)
  feat: dynamic title and description (formbricks#1459)
  fix: Spelling Errors (formbricks#1517)
  fix: added scrollbar whenever overflowed in the settings/profile page (formbricks#1498)
  fix: long url not getting reset after closing modal (formbricks#1502)
  fix: Unexpected Behavior when Toggling Italics in Text Editor and improve clarity of formatting status (formbricks#1506)
  fix: zod pin validation failing (formbricks#1507)
  fix: Error message on Login not shown  (formbricks#1508)
  fix: downgrade nextjs to fix error with react email (formbricks#1516)
  chore: downgrade next version in formbricks-com (formbricks#1513)
  feat: picture selection question (formbricks#1388)
  feat: formtribe leaderboard update as per today (formbricks#1505)
  fix: Added if statement for preventing use of reserved word in question ID (formbricks#1435)
  fix: Disabling Welcome Card leads buggy preview (formbricks#1320)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants