Upgraded EUI 13.0.0 -> 13.1.1 by chandlerprall · Pull Request #42298 · elastic/kibana

chandlerprall · 2019-07-30T20:22:39Z

Summary

Updates to the latest EUI; observed snapshot changes were expected:

EuiDatePicker has a new default prop, isDisabled={false}
aria-describedby no longer applied to tooltip buttons unless tooltip is visible
EuiFilePicker's styling has been updated

`13.1.1`

Bug fixes

Fixed EuiMutationObserver errors in IE11 by conditionally setting the attributes observer option according to the new spec (#2180)
Fixed error message when an I18n mapping is a formatting function with no values provided. (#2182)

`13.1.0`

Added partial glyph to EuiIcon (#2152)
Added tall, fullWidth, and isInvalid props to EuiFilePicker (#2145)
Added exports for react-beautiful-dnd interfaces used by EUI components (#2173)
Added isDisabled prop & styles to EuiSuperDatePicker (#2139)
Added responsiveColumn option to type prop of EuiDescriptionList (#2166)
Removed <use> and <def> from svg icons (#2162)

Bug fixes

Fixed invalid aria-desribedby values set by EuiToolTip (#2156)
Added "center" as an acceptable value to EuiBasicTable's align proptype (#2158)
Fixed .eui-textBreakWord utility class to be cross-browser compatible (#2157)
Fixed truncation and z-index of EuiFilePicker (#2145)
Fixed EuiNavDrawer's support for flyout groups in production/minified builds (#2178)
Fixed width overflow of EuiModal (#2164)

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support~~
~~- [ ] Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~- [ ] This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
~~- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately~~

elasticmachine · 2019-07-30T21:26:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

snide

Pulled down and check over changes.

thompsongl

Changes LGTM

elasticmachine · 2019-07-31T19:53:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chandlerprall · 2019-08-01T02:37:02Z

jenkins test this

elasticmachine · 2019-08-01T03:35:09Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

poffdeluxe

Canvas updated snapshots look good

chandlerprall · 2019-08-01T14:28:11Z

@elastic/ml-ui could I get a review please?

thompsongl · 2019-08-01T15:40:05Z

Fixed EuiMutationObserver errors in IE11 by conditionally setting the attributes observer option according to the new spec

Do we want to remove the polyfill changes for Jest now that EUI handles it?

chandlerprall · 2019-08-01T18:48:19Z

Thanks @thompsongl , pushed that up

jbudz

srv/dev/jest LGTM

src/dev/jest/setup/polyfills.js

elasticmachine · 2019-08-02T18:33:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

* Upgraded EUI 13.0.0 -> 13.1.0 * Bump to 13.1.1 * Reset MutationObserver polyfill to original operation * Reset x-pack's MutationObserver polyfill to original operation

Upgraded EUI 13.0.0 -> 13.1.0

ba1a173

chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 :Design labels Jul 30, 2019

chandlerprall requested review from a team, snide and thompsongl July 30, 2019 20:22

chandlerprall requested review from a team as code owners July 30, 2019 20:22

chandlerprall added v7.3.1 and removed v7.3.1 labels Jul 31, 2019

snide approved these changes Jul 31, 2019

View reviewed changes

sorenlouv approved these changes Jul 31, 2019

View reviewed changes

thompsongl approved these changes Jul 31, 2019

View reviewed changes

Bump to 13.1.1

07e1cb4

chandlerprall changed the title ~~Upgraded EUI 13.0.0 -> 13.1.0~~ Upgraded EUI 13.0.0 -> 13.1.1 Jul 31, 2019

poffdeluxe approved these changes Aug 1, 2019

View reviewed changes

thompsongl self-requested a review August 1, 2019 15:38

Reset MutationObserver polyfill to original operation

f3f2a4c

chandlerprall requested a review from a team as a code owner August 1, 2019 18:48

jbudz approved these changes Aug 1, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into eui-13.1.0

7dc1107

thompsongl suggested changes Aug 1, 2019

View reviewed changes

src/dev/jest/setup/polyfills.js Show resolved Hide resolved

Reset x-pack's MutationObserver polyfill to original operation

5a3c903

chandlerprall requested a review from thompsongl August 2, 2019 17:24

thompsongl approved these changes Aug 2, 2019

View reviewed changes

chandlerprall merged commit da99d45 into elastic:master Aug 2, 2019

chandlerprall deleted the eui-13.1.0 branch August 2, 2019 18:42

chandlerprall mentioned this pull request Aug 5, 2019

[7.x] Upgraded EUI 13.0.0 -> 13.1.1 (#42298) #42604

Merged

This was referenced Aug 26, 2019

Long Username "breaks" Delete Confirmation Dialog #43862

Closed

[Spaces] When the space name is long the UI is breaking #23302

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgraded EUI 13.0.0 -> 13.1.1#42298

Upgraded EUI 13.0.0 -> 13.1.1#42298
chandlerprall merged 5 commits intoelastic:masterfrom
chandlerprall:eui-13.1.0

chandlerprall commented Jul 30, 2019 •

edited

Loading

Uh oh!

elasticmachine commented Jul 30, 2019

Uh oh!

snide left a comment

Uh oh!

thompsongl left a comment

Uh oh!

elasticmachine commented Jul 31, 2019

Uh oh!

chandlerprall commented Aug 1, 2019

Uh oh!

elasticmachine commented Aug 1, 2019

Uh oh!

poffdeluxe left a comment

Uh oh!

chandlerprall commented Aug 1, 2019

Uh oh!

thompsongl commented Aug 1, 2019

Uh oh!

chandlerprall commented Aug 1, 2019

Uh oh!

jbudz left a comment

Uh oh!

Uh oh!

elasticmachine commented Aug 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

chandlerprall commented Jul 30, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

13.1.1

13.1.0

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 30, 2019

💚 Build Succeeded

Uh oh!

snide left a comment

Choose a reason for hiding this comment

Uh oh!

thompsongl left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 31, 2019

💔 Build Failed

Uh oh!

chandlerprall commented Aug 1, 2019

Uh oh!

elasticmachine commented Aug 1, 2019

💚 Build Succeeded

Uh oh!

poffdeluxe left a comment

Choose a reason for hiding this comment

Uh oh!

chandlerprall commented Aug 1, 2019

Uh oh!

thompsongl commented Aug 1, 2019

Uh oh!

chandlerprall commented Aug 1, 2019

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chandlerprall commented Jul 30, 2019 •

edited

Loading

`13.1.1`

`13.1.0`