Skip to content

Update EuiBasicTable's column proptype to support 'center' value for align#2158

Merged
chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall:bug/2153-no-center-align-prop-value
Jul 23, 2019
Merged

Update EuiBasicTable's column proptype to support 'center' value for align#2158
chandlerprall merged 2 commits intoelastic:masterfrom
chandlerprall:bug/2153-no-center-align-prop-value

Conversation

@chandlerprall
Copy link
Copy Markdown
Contributor

@chandlerprall chandlerprall commented Jul 23, 2019

Summary

Closes #2153 , small addition of "center" to the table's column align proptype. "center" is supported by the table header, footer, and cell components.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode

  • Any props added have proper autodocs
    - [ ] Documentation examples were added
  • A changelog entry exists and is marked appropriately
  • This was checked for breaking changes and labeled appropriately
    - [ ] Jest tests were updated or added to match the most common scenarios
    - [ ] This was checked against keyboard-only and screenreader scenarios
    - [ ] This required updates to Framer X components

@chandlerprall chandlerprall requested a review from thompsongl July 23, 2019 15:29
Copy link
Copy Markdown
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chandlerprall chandlerprall merged commit 5300e0b into elastic:master Jul 23, 2019
@chandlerprall chandlerprall deleted the bug/2153-no-center-align-prop-value branch July 23, 2019 17:19
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
…align (elastic#2158)

* Update EuiBasicTable's column proptype to support 'center' value for align

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EuiBasicTable align prop - missing center

2 participants