Skip to content

[Metric Vis] Shim new platform#42240

Merged
alexwizp merged 9 commits intoelastic:masterfrom
alexwizp:metric-vis
Aug 5, 2019
Merged

[Metric Vis] Shim new platform#42240
alexwizp merged 9 commits intoelastic:masterfrom
alexwizp:metric-vis

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Jul 30, 2019

Summary

Part of #41669

First step of migrating to new Platform

What was done in this PR:

  • Have a new platform-style plugin definition in typescript, with a setup method returning the public contract (see data plugin as an example). This needs to be exported from the top-level /server and/or /public directory, e.g. export foo = new Plugin.setup()
  • Be broken into logical "services", each with a service definition class (see data plugin as an example)
  • Register the visualization via the "visualizations" plugin's types service.
  • Have all static exports done from the top level plugin definition

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp force-pushed the metric-vis branch 2 times, most recently from 33fc8ec to bd663e1 Compare July 30, 2019 12:42
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 30, 2019

💚 Build Succeeded

@alexwizp alexwizp marked this pull request as ready for review July 30, 2019 13:44
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 30, 2019

Pinging @elastic/kibana-app-arch

@alexwizp alexwizp added release_note:skip Skip the PR/issue when compiling release notes Feature:MetricVis Metric visualization feature labels Jul 30, 2019
@elastic elastic deleted a comment from elasticmachine Jul 30, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 30, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jul 31, 2019

💚 Build Succeeded

@elastic elastic deleted a comment from elasticmachine Aug 1, 2019
@elastic elastic deleted a comment from elasticmachine Aug 1, 2019
@alexwizp alexwizp self-assigned this Aug 1, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 1, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 3, 2019

💚 Build Succeeded

lukeelmers
lukeelmers reviewed Aug 5, 2019
View reviewed changes
src/legacy/core_plugins/metric_vis/public/metric_vis_fn.ts
fn(context, args) {

const dimensions = {
fn(context: Context, args: Arguments) {
Copy link
Copy Markdown
Contributor

@lukeelmers lukeelmers Aug 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: context, args types not needed here

@alexwizp alexwizp merged commit 51c48b7 into elastic:master Aug 5, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Aug 5, 2019
@alexwizp
[Metric Vis] Shim new platform (elastic#42240)
26fda0b 
* Add New Platform mocks for data plugin

* [Metric Vis] Shim new platform

* move metric_vis_controller to components folder

* fix PR comments

* change interpreter type for colorRange and font

* change interpreter type for colorRange and font
@alexwizp alexwizp mentioned this pull request Aug 5, 2019
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/clone…
ad759ef 
…-or-edit-existing-rollup-job

* 'master' of github.com:elastic/kibana: (67 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
@lukeelmers lukeelmers mentioned this pull request Aug 5, 2019
Closed
jloleysens added a commit to jloleysens/kibana that referenced this pull request Aug 5, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/doc_value…
b366497 
…s_autocomplete

* 'master' of github.com:elastic/kibana: (189 commits)
  [TSVB] Shim new platform (elastic#39169)
  [Metric Vis] Shim new platform (elastic#42240)
  [Tag Cloud] Shim new platform (elastic#42348)
  Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS.
  Add disk space percentage to node listing (elastic#42145)
  [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440)
  Document HTTP service (elastic#42331)
  [Reporting] Sanitize 409 error log message (elastic#42495)
  [docs][skip ci] Maps read only access (elastic#35561)
  [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407)
  [DOCS] Updates images and content in Dashboard docs (elastic#42500)
  Allow sorting on multiple columns in Discover (elastic#41918)
  [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287)
  [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534)
  Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298)
  Increase max-old-space-size for builds (elastic#42218)
  [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836)
  [Logs UI][a11y] Announce name of column on remove column button (elastic#41695)
  Inspector 👉 New Platform (elastic#42164)
  Make alerting properly space aware (elastic#42081)
  ...
alexwizp added a commit that referenced this pull request Aug 5, 2019
@alexwizp
[Metric Vis] Shim new platform (#42240) (#42577)
92a3e2b 
* Add New Platform mocks for data plugin

* [Metric Vis] Shim new platform

* move metric_vis_controller to components folder

* fix PR comments

* change interpreter type for colorRange and font

* change interpreter type for colorRange and font
@alexwizp alexwizp deleted the metric-vis branch January 4, 2020 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lukeelmers lukeelmers lukeelmers approved these changes

@streamich streamich Awaiting requested review from streamich

@lizozom lizozom Awaiting requested review from lizozom

@thomasneirynck thomasneirynck Awaiting requested review from thomasneirynck

@nreese nreese Awaiting requested review from nreese

Assignees

@alexwizp alexwizp

Labels

Feature:MetricVis Metric visualization feature Feature:NP Migration release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexwizp @elasticmachine @lukeelmers