[DOCS] Updates images and content in Dashboard docs#42500
Merged
gchaps merged 3 commits intoelastic:masterfrom Aug 2, 2019
Merged
[DOCS] Updates images and content in Dashboard docs#42500gchaps merged 3 commits intoelastic:masterfrom
gchaps merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-docs |
timroes
reviewed
Aug 2, 2019
docs/dashboard.asciidoc
Outdated
|
|
||
| Once you open a dashboard, you can filter the data | ||
| by entering a search query, changing the time filter, or clicking | ||
| in the visualization, search, or map. If a dashboard element has a stored query, |
Contributor
There was a problem hiding this comment.
wouldn't that be "clicking in a visualization, search, or map" or "clicking in the visualizations, searches, or maps"?
timroes
approved these changes
Aug 2, 2019
Contributor
timroes
left a comment
There was a problem hiding this comment.
Besides two minor questions/suggestions this looks good to me.
docs/dashboard.asciidoc
Outdated
|
|
||
| TIP: When sharing a link to a dashboard snapshot, use the *Short URL*. Snapshot | ||
| URLs are long and can be problematic for Internet Explorer and other | ||
| tools. To create a short URL, you must have write access to {kib}. |
Contributor
There was a problem hiding this comment.
Double Space: "tools. To" (though I think asciidoc will ignore those?
KOTungseth
approved these changes
Aug 2, 2019
Contributor
KOTungseth
left a comment
There was a problem hiding this comment.
I have a few tiny comments, but otherwise, this PR looks great.
docs/dashboard.asciidoc
Outdated
|
|
||
| -- | ||
| To start working with dashboards, click *Dashboard* in the side navigation. | ||
| You can: |
Contributor
There was a problem hiding this comment.
How about:
With dashboards, you can:
|
|
||
| [float] | ||
| [[dashboard-read-only-access]] | ||
| === [xpack]#Read only access# |
Contributor
There was a problem hiding this comment.
Totally outside the parameters of this PR, but could we make this an attribute? I've been sticking this text in my PRs too, so I'm wondering if we could keep and maintain it in one place?
|
|
||
| When you open *Dashhboard*, you're presented an overview of your dashboards. | ||
| If you don't have any dashboards, you can add | ||
| <<add-sample-data, sample data sets>>, |
Contributor
There was a problem hiding this comment.
How about:
...you can add sample data sets and check out the pre-built dashboards.
or:
you can add sample data sets, or checkout the pre-built dashboards.
gchaps
added a commit
that referenced
this pull request
Aug 2, 2019
* [DOCS] Updates images and content in Dashboard docs * [DOCS] Incorporated feedback
gchaps
added a commit
that referenced
this pull request
Aug 2, 2019
* [DOCS] Updates images and content in Dashboard docs * [DOCS] Incorporated feedback
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 5, 2019
…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...
gchaps
added a commit
that referenced
this pull request
Aug 5, 2019
* [DOCS] Updates images and content in Dashboard docs * [DOCS] Incorporated feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes the following changes to the Dashboard docs:
A formatted version of the doc is here.
[skip ci]