[Logs UI][a11y] Announce name of column on remove column button by Zacqary · Pull Request #41695 · elastic/kibana

Zacqary · 2019-07-22T18:46:32Z

Summary

Adds the column name to "Remove this column" button descriptions when using a screen reader. Tested on Mac VoiceOver in Chrome; can someone with access to a Windows machine please test this?

Was also unable to test in Firefox because it's apparently not compatible with VoiceOver, but it does produce the correct aria-label attributes.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

~~[ ] This was checked for cross-browser compatibility, including a check against IE11~~
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~[ ] Documentation was added for features that require explanation or tutorials~~
~~[ ] Unit or functional tests were updated or added to match the most common scenarios~~
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-07-22T18:46:35Z

Pinging @elastic/infra-logs-ui

elasticmachine · 2019-07-22T19:41:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…unce

elasticmachine · 2019-07-22T22:12:58Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Zacqary · 2019-07-23T15:23:28Z

retest

elasticmachine · 2019-07-23T16:25:18Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…announce

hbharding

LGTM, but I might suggest changing the Voice Over language to Remove <message> column, button as it's faster to recognize the context. Hearing Remove this column: ... Remove this column: ... Remove this column: ... over and over again requires the listener to wait for the important bit of information.

elasticmachine · 2019-07-24T22:17:39Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…unce

…announce

…o 40421-column-announce

hbharding

lgtm

elasticmachine · 2019-07-29T19:13:38Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-29T20:50:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

jasonrhodes

LGTM -- I don't think we need to block ourselves on waiting to test these in Windows. Most things are roughly the same enough that focusing on fixing them in "screen readers" is a good first-step goal. As they continue to audit the code, windows-only bugs may pop up and we will need a better way to be able to easily spin up a Windows test at that point, perhaps.

Thanks!

…announce

elasticmachine · 2019-08-01T23:33:02Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

Zacqary · 2019-08-01T23:39:21Z

retest

elasticdog · 2019-08-01T23:52:39Z

retest

elasticmachine · 2019-08-02T01:04:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

…tic#41695) * [Logs UI][a11y] Announce name of column on remove column button * Use title instead of aria-label * ariaColumnName => columnDescription * Move template string out of i18n * Revert label id change * Inject i18n to field title * Change title to Remove {columnDescription} column * Replace injectI18N with i18n.translate * Fix i18n

…) (#42529) * [Logs UI][a11y] Announce name of column on remove column button * Use title instead of aria-label * ariaColumnName => columnDescription * Move template string out of i18n * Revert label id change * Inject i18n to field title * Change title to Remove {columnDescription} column * Replace injectI18N with i18n.translate * Fix i18n

…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

Zacqary added 2 commits July 22, 2019 13:38

[Logs UI][a11y] Announce name of column on remove column button

35d5da2

Use title instead of aria-label

e37398a

Zacqary added Project:Accessibility WCAG A v8.0.0 Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services v7.4.0 labels Jul 22, 2019

Zacqary requested a review from a team July 22, 2019 18:46

ariaColumnName => columnDescription

237d340

Zacqary added the release_note:fix label Jul 22, 2019

Zacqary added 4 commits July 22, 2019 15:57

Move template string out of i18n

48d234c

Revert label id change

a927750

Inject i18n to field title

91545f5

Merge remote-tracking branch 'upstream/master' into 40421-column-anno…

d115716

…unce

Merge branch 'master' of github.com:elastic/kibana into 40421-column-…

3add938

…announce

hbharding self-requested a review July 24, 2019 21:42

hbharding reviewed Jul 24, 2019

View reviewed changes

Zacqary added 5 commits July 25, 2019 12:28

Merge remote-tracking branch 'upstream/master' into 40421-column-anno…

5b30df1

…unce

Merge branch 'master' of github.com:elastic/kibana into 40421-column-…

17e31f1

…announce

Change title to Remove {columnDescription} column

9103ac8

Merge branch '40421-column-announce' of github.com:Zacqary/kibana int…

cfa8b13

…o 40421-column-announce

Replace injectI18N with i18n.translate

0094169

hbharding approved these changes Jul 29, 2019

View reviewed changes

Fix i18n

c8c682c

jasonrhodes approved these changes Aug 1, 2019

View reviewed changes

Merge branch 'master' of github.com:elastic/kibana into 40421-column-…

5e2fda0

…announce

Zacqary merged commit a9e0f25 into elastic:master Aug 2, 2019

Zacqary deleted the 40421-column-announce branch August 2, 2019 15:20

Zacqary mentioned this pull request Aug 2, 2019

[7.x] [Logs UI][a11y] Announce name of column on remove column button (#41695) #42529

Merged

Conversation

Zacqary commented Jul 22, 2019

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 22, 2019

Uh oh!

elasticmachine commented Jul 22, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 22, 2019

💔 Build Failed

Uh oh!

Zacqary commented Jul 23, 2019

Uh oh!

elasticmachine commented Jul 23, 2019

💚 Build Succeeded

Uh oh!

hbharding left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 24, 2019

💚 Build Succeeded

Uh oh!

hbharding left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 29, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 29, 2019

💚 Build Succeeded

Uh oh!

jasonrhodes left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Aug 1, 2019

💔 Build Failed

Uh oh!

Zacqary commented Aug 1, 2019

Uh oh!

elasticdog commented Aug 1, 2019

Uh oh!

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants