Add disk space percentage to node listing by cachedout · Pull Request #42145 · elastic/kibana

cachedout · 2019-07-29T13:46:26Z

Summary

This PR updates the Stack Monitoring application so that when a user view the overview page for a given Elasticsearch node, they see the amount of disk space that is available both as a raw value and as a percentage of the space available.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
~~Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support!!
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-07-29T14:54:13Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-31T10:54:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-31T12:16:27Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

chrisronline

Looks great! One suggestion though!

x-pack/legacy/plugins/monitoring/public/components/elasticsearch/node_detail_status/index.js

chrisronline

LGTM (Pending tests passing)! Nice work!

elasticmachine · 2019-07-31T16:17:24Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-31T17:06:10Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-07-31T18:04:06Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

igoristic · 2019-07-31T18:22:20Z

Looks good 👍

elasticmachine · 2019-08-02T12:24:14Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-08-03T11:00:28Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

chrisronline · 2019-08-03T14:52:23Z

@cachedout Can you please add version labels and perform any necessary backporting too?

elasticmachine · 2019-08-03T14:52:39Z

Pinging @elastic/stack-monitoring

…-or-edit-existing-rollup-job * 'master' of github.com:elastic/kibana: (67 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

…s_autocomplete * 'master' of github.com:elastic/kibana: (189 commits) [TSVB] Shim new platform (elastic#39169) [Metric Vis] Shim new platform (elastic#42240) [Tag Cloud] Shim new platform (elastic#42348) Disable flaky request lib tests. Add es_ui_shared plugin to CODEOWNERS. Add disk space percentage to node listing (elastic#42145) [SIEM] Add chart interactions - update date picker after brush selection on charts (elastic#42440) Document HTTP service (elastic#42331) [Reporting] Sanitize 409 error log message (elastic#42495) [docs][skip ci] Maps read only access (elastic#35561) [x-pack/ftr] refactor types to be more accurate/consistent wit… (elastic#42407) [DOCS] Updates images and content in Dashboard docs (elastic#42500) Allow sorting on multiple columns in Discover (elastic#41918) [Infra UI][Logs UI] Fix autocomplete to use proper derived index pattern (elastic#42287) [ftr/cheerio] improve cheerio types to include test subject me… (elastic#42534) Upgraded EUI 13.0.0 -> 13.1.1 (elastic#42298) Increase max-old-space-size for builds (elastic#42218) [Infra UI] Add cloud metrics and cloud/host info to metadata endpoint (elastic#41836) [Logs UI][a11y] Announce name of column on remove column button (elastic#41695) Inspector 👉 New Platform (elastic#42164) Make alerting properly space aware (elastic#42081) ...

chrisronline · 2019-08-08T13:19:59Z

@cachedout Polite bump :)

* Add disk space percentage to node listing * Test modification for totalSpace * Fix test mockup * Add totalSpace to fixture * Test fixup * Remove trailing space per review suggestion * More fixture updates * More fixture update * More fixture updates * Update mock * More fixture changes

cachedout requested review from chrisronline and igoristic July 29, 2019 13:46

cachedout added the release_note:enhancement label Jul 29, 2019

cachedout force-pushed the disk_space_percentage branch from 2c1971b to fde41f1 Compare July 29, 2019 13:52

cachedout force-pushed the disk_space_percentage branch from fde41f1 to 350f1f5 Compare July 31, 2019 09:48

chrisronline suggested changes Jul 31, 2019

View reviewed changes

x-pack/legacy/plugins/monitoring/public/components/elasticsearch/node_detail_status/index.js Outdated Show resolved Hide resolved

chrisronline approved these changes Jul 31, 2019

View reviewed changes

igoristic approved these changes Jul 31, 2019

View reviewed changes

cachedout added 11 commits August 3, 2019 11:51

Add disk space percentage to node listing

01a2839

Test modification for totalSpace

2a9fcd2

Fix test mockup

4ab5c0d

Add totalSpace to fixture

d4f67a5

Test fixup

3afe2ee

Remove trailing space per review suggestion

170fe9c

More fixture updates

a27d55e

More fixture update

659ef38

More fixture updates

adf7eed

Update mock

47f5d99

More fixture changes

7747c2d

cachedout force-pushed the disk_space_percentage branch from db23229 to 7747c2d Compare August 3, 2019 09:52

cachedout merged commit 15c43b7 into elastic:master Aug 3, 2019

chrisronline added the Team:Monitoring Stack Monitoring team label Aug 3, 2019

cachedout mentioned this pull request Aug 12, 2019

[7.x] Add disk space percentage to node listing (#42145) #43142

Merged

Conversation

cachedout commented Jul 29, 2019

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Jul 29, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 31, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 31, 2019

💔 Build Failed

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chrisronline left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 31, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 31, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Jul 31, 2019

💔 Build Failed

Uh oh!

igoristic commented Jul 31, 2019

Uh oh!

elasticmachine commented Aug 2, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Aug 3, 2019

💚 Build Succeeded

Uh oh!

chrisronline commented Aug 3, 2019

Uh oh!

elasticmachine commented Aug 3, 2019

Uh oh!

chrisronline commented Aug 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants