Add overflow: hidden to .euiModal__flex#2164
Merged
cchaos merged 5 commits intoelastic:masterfrom Jul 29, 2019
Merged
Conversation
Contributor
Author
|
When I was checking in IE, there's always been this problem where IE wouldn't grow the width of the modal unless you explicitely gave it a width. I found the answer which is just expanding the So this fix is included in the PR as well. |
thompsongl
approved these changes
Jul 25, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
I'm good with this. I agree that it doesn't close the long title issues, but it's definitely less broken.
5 tasks
ryankeairns
approved these changes
Jul 29, 2019
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM.
I gave up on verifying this in Kibana (I can't figure out the new linking; Kibana keeps crashing), but it does work as described in my local EUI docs. I'll check it again once Kibana is updated with this new EUI build.
3 tasks
This was referenced Aug 26, 2019
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
This was referenced Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was discovered in Kibana that even non-breaking words in code blocks inside of modals causes the content to overflow the body even though code blocks are setup to scroll.
https://d.pr/free/v/l0r1A1
This just hides any overflow from
.euiModal__flex. Here's some tests in EUI docs:Code blocks
Before
After
Also fixes #1762
Also "fixes" long titles #1766 #1384
... though it just really cuts it off and doesn't force it to break the word so I'm hesistent to call the above issues fixed and closed.
Checklist
[ ] This was checked in dark mode[ ] Any props added have proper autodocs[ ] Documentation examples were added[ ] This was checked for breaking changes and labeled appropriately[ ] Jest tests were updated or added to match the most common scenarios[ ] This was checked against keyboard-only and screenreader scenarios[ ] This required updates to Framer X components