Fix invalid aria-describedby values set by EuiToolTip (#1533)#2156
Merged
myasonik merged 1 commit intoelastic:masterfrom Jul 23, 2019
Merged
Fix invalid aria-describedby values set by EuiToolTip (#1533)#2156myasonik merged 1 commit intoelastic:masterfrom
myasonik merged 1 commit intoelastic:masterfrom
Conversation
8638dd8 to
6b3b498
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tooltips have been adding their id to their anchor element as an
aria-describedbyattribute but that trips up a11y testing tools because the tooltips don't exist until after they're activated.This change sets
aria-describedbyonly when the tooltip is shown.Closes #1533
Checklist
- [ ] This was checked in mobile- [ ] This was checked in IE11- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] This was checked for breaking changes and labeled appropriately- [ ] This required updates to Framer X components