Fix EuiNavDrawer to not rely on managleable function names#2178
Merged
chandlerprall merged 2 commits intoelastic:masterfrom Jul 29, 2019
Merged
Conversation
thompsongl
approved these changes
Jul 29, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM. Built docs and tested manually with a local server. Verified it still works in with the dev build, also.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2175
When minified,
EuiNavDrawerGroup's function name is shortened/mangled which caused the logic inEuiNavDrawerto break:if (child.type.name === 'EuiNavDrawerGroup') {Instead of relying on the string name, this changes the logic to check for identity instead.
Checklist
- [ ] Checked in dark mode- [ ] Checked in mobile- [ ] Checked in IE11 and Firefox- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes