Add isDisabled prop to EuiSuperDatePicker#2139
Merged
chandlerprall merged 6 commits intoelastic:masterfrom Jul 26, 2019
Merged
Conversation
Contributor
|
PR4U: chandlerprall#9 |
- Had to also add a `isDisabled` prop to EuiFormControlLayout
Contributor
Author
|
Thanks @cchaos !! |
thompsongl
approved these changes
Jul 22, 2019
Contributor
thompsongl
left a comment
There was a problem hiding this comment.
LGTM. Tested locally in the docs
ryankeairns
approved these changes
Jul 26, 2019
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
LGTM, works as I would expect and looks good visually.
3 tasks
thompsongl
pushed a commit
to thompsongl/eui
that referenced
this pull request
Sep 10, 2019
* initial disabling * Allow EuiSuperDatePicker to be disabled via isDisabled prop * Styling for disabled states - Had to also add a `isDisabled` prop to EuiFormControlLayout * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2081. Adds a
isDisabledprop toEuiSuperDatePickerwhich disables interactions with the various controls.euiSuperDatePicker__prettyFormat--disabledandeuiDatePopoverButton-disabledChecklist
Jest tests were updated or added to match the most common scenariosThis required updates to Framer X components