Skip to content

Polls in meetings#8065

Merged
leio10 merged 30 commits intodevelopfrom
feat/answer-poll-in-meeting
Jun 14, 2021
Merged

Polls in meetings#8065
leio10 merged 30 commits intodevelopfrom
feat/answer-poll-in-meeting

Conversation

@ferblape
Copy link
Copy Markdown
Contributor

@ferblape ferblape commented May 27, 2021

🎩 What? Why?

This PR allows to add polls to online meetings.

As an admin:

  • admins can create a questionnaire with two types of questsions (single option and multiple option) in the admin meeting UI. To access to it there's a new option in the meetings list
  • lot of work from decidim-forms has been reused, also as many classes as possible has been re-used, but as there were some critical differences we've had to declare new classes (Question, Answer, ....)
  • when the admin visits the live event (in the public web) she can see a button Administrate that allows to change the state of the questions:
    • from unpublished to published, so the question is visible for attendees to respond. When questions are replied she can see the number of replies and a preview of the results
    • from published to closed, in which case the results are displayed to users, that can't reply anymore
  • also admins can export questions and answers in common formats (CSV, JSON...) from the admin UI, to allow them to view data once the meeting has finished

As a user:

  • when a user visits a live meeting there's a new access CTA
  • in this new layout users have a button Questions that opens a sidebar
  • the sidebar reloads automatically using a basic polling (based on comments polling). The polling has a timeout of 5 seconds, it can be adjusted
  • users can reply and see results of questsions, depending on its state

Notice that the current page to answer the poll only contains the poll, but there's a reserved space for the videoconference iframe that will be filled up in #7716, #7724 and other related issues.

📌 Related Issues

Testing

As an admin:

  • create a questionnaire, add different types of questions, add max limit of chosen options
  • validate questions can be updated
  • validate questions can't be updated once there are answers
  • validate questions and answers can be exported
  • validate can administrate questions in the live event page: change state, preview results, close questions

As a user:

  • validate can see published and closed questiosn in the live event page
  • validate questions are updated via polling
  • validate can answer questions
  • validate can see replies in closed questions

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Admin UI:

Screenshot from 2021-05-28 16-10-16

List questions for admins:

Screenshot from 2021-05-28 16-10-27

List questions for users:

Screenshot from 2021-05-28 16-10-38

♥️ Thank you!

@ferblape ferblape force-pushed the feat/answer-poll-in-meeting branch from 5283ed7 to 77d3012 Compare May 28, 2021 10:08
@ferblape ferblape changed the title Answer polls in meetings Polls in meetings May 28, 2021
@ferblape ferblape marked this pull request as ready for review May 29, 2021 05:15
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
leio10
leio10 previously approved these changes Jun 11, 2021
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and huge work! 👏 👍
I have just one comment, let's address it and we can merge this.

@leio10 leio10 merged commit c2ee66c into develop Jun 14, 2021
@leio10 leio10 deleted the feat/answer-poll-in-meeting branch June 14, 2021 11:27
entantoencuanto added a commit that referenced this pull request Jun 29, 2021
* develop: (47 commits)
  New Crowdin updates (#8150)
  Move the webpacker config override to @decidim/webpacker (#8158)
  Fix admin stylesheet dynamic imports (#8154)
  Fix session timeout conflicting with remember me (#7467)
  Allow to create online meetings without an URL (#8152)
  Fix verification route issues (#8146)
  Fix dont save timeout path to session (#8142)
  Fix access to import CSV results in accountability (#8132)
  Fix user report notification reported user name (#8130)
  Allow users to comment and delete their own comments (#8072)
  New Crowdin updates (#8124)
  Fix webpacker issues (#8136)
  Add comments in participatory space presentation page stats block (#8034)
  Split NPM dependencies to more granular packages (#8121)
  Metric is not shown when value is zero for blocked and reported users (#8117)
  Add missing templates translations (#8133)
  Add missing translation for authorization_modals (#8129)
  Polls in meetings (#8065)
  Fix flaky test on initiatives (#8128)
  Filter participants admin (#8104)
  ...
@leio10 leio10 mentioned this pull request Jul 21, 2021
12 tasks
@andreslucena andreslucena mentioned this pull request Sep 15, 2021
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

3 participants