Skip to content

Allow users to comment and delete their own comments#8072

Merged
leio10 merged 22 commits intodevelopfrom
7909-comments-context-menu
Jun 21, 2021
Merged

Allow users to comment and delete their own comments#8072
leio10 merged 22 commits intodevelopfrom
7909-comments-context-menu

Conversation

@Crashillo
Copy link
Copy Markdown
Contributor

@Crashillo Crashillo commented May 28, 2021

🎩 What? Why?

Design. Add a context menu for each comment. The toggle function uses the checkbox hack, so no js required
Feature: This PR:

  • Adds a deleted_at attribute to comments
  • Allows users to delete their own comments. The deletion action appears in the context menu when available for each comment. The deleted comments appear in the comments list with a message of deletion displaying the deleted_at datetime.
  • Allows users to edit their own comments. The edition action appears in the context menu when available for each comment. All edited comments display an "Edited" message.
  • When a user edits a comment, the associated ActionLog entry includes an extra: { edit: true }. This allows the application to detect if a comment has changes made by user
  • Adds some tests

📌 Related Issues

Screenshot

Grabacion.de.pantalla.2021-05-28.a.las.10.34.01.mov

z-index: 1;
padding: 0;
margin: 0;
box-shadow: 0px 2px 8px rgba(0, 0, 0, 0.25);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected unit (length-zero-no-unit)

z-index: 1;
padding: 0;
margin: 0;
box-shadow: 0px 2px 8px rgba(0, 0, 0, 0.25);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unexpected leading zero (number-leading-zero)

@entantoencuanto entantoencuanto force-pushed the 7909-comments-context-menu branch 4 times, most recently from c671b7c to ca344f2 Compare June 4, 2021 16:52
@entantoencuanto entantoencuanto force-pushed the 7909-comments-context-menu branch from ca344f2 to 7b2c572 Compare June 4, 2021 16:58
@entantoencuanto entantoencuanto force-pushed the 7909-comments-context-menu branch from 7b2c572 to 59a7a27 Compare June 4, 2021 18:37
@andreslucena
Copy link
Copy Markdown
Member

Hi @Crashillo
I've skimmed in the PR and I see that this is not only design-related, but all the functionality described at #7909 and #7908. Could you please update the description/title of this PR 🙏🏽? Thanks

@entantoencuanto entantoencuanto changed the title Comments context menu Allow users to comment and delete their own comments Jun 17, 2021
@entantoencuanto
Copy link
Copy Markdown
Contributor

Updated title and description, @andreslucena

Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job!! 👏👏👏

@leio10 leio10 merged commit 492cb84 into develop Jun 21, 2021
@leio10 leio10 deleted the 7909-comments-context-menu branch June 21, 2021 16:40
entantoencuanto added a commit that referenced this pull request Jun 29, 2021
* develop: (47 commits)
  New Crowdin updates (#8150)
  Move the webpacker config override to @decidim/webpacker (#8158)
  Fix admin stylesheet dynamic imports (#8154)
  Fix session timeout conflicting with remember me (#7467)
  Allow to create online meetings without an URL (#8152)
  Fix verification route issues (#8146)
  Fix dont save timeout path to session (#8142)
  Fix access to import CSV results in accountability (#8132)
  Fix user report notification reported user name (#8130)
  Allow users to comment and delete their own comments (#8072)
  New Crowdin updates (#8124)
  Fix webpacker issues (#8136)
  Add comments in participatory space presentation page stats block (#8034)
  Split NPM dependencies to more granular packages (#8121)
  Metric is not shown when value is zero for blocked and reported users (#8117)
  Add missing templates translations (#8133)
  Add missing translation for authorization_modals (#8129)
  Polls in meetings (#8065)
  Fix flaky test on initiatives (#8128)
  Filter participants admin (#8104)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit my comment Delete my comment

4 participants