Skip to content

Add missing templates translations#8133

Merged
leio10 merged 3 commits intodecidim:developfrom
CodiTramuntana:fix/missing_templates_translations
Jun 14, 2021
Merged

Add missing templates translations#8133
leio10 merged 3 commits intodecidim:developfrom
CodiTramuntana:fix/missing_templates_translations

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

🎩 What? Why?

In the admin of the templates module there are missing translations for Template and Questionnaire classes.

📌 Related Issues

Link your PR to an issue

  • Related to #?
  • Fixes #?

Testing

Describe the best way to test or validate your PR.

  1. Go to the admin and create a new template: name and description are not translated
  2. Go to the admin and edit a question: title is not translated

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Create new template without translations
imatge

Edit questionnaire without translation
imatge

♥️ Thank you!

@leio10 leio10 added in-review module: admin type: fix PRs that implement a fix for a bug labels Jun 14, 2021
@leio10 leio10 changed the title Fix/missing templates translations Add missing templates translations Jun 14, 2021
@leio10 leio10 merged commit 54cec16 into decidim:develop Jun 14, 2021
@leio10
Copy link
Copy Markdown
Contributor

leio10 commented Jun 14, 2021

@tramuntanal Can you create a backport for the v0.24? Thanks! ❤️

@tramuntanal tramuntanal deleted the fix/missing_templates_translations branch June 15, 2021 05:46
tramuntanal added a commit to CodiTramuntana/decidim that referenced this pull request Jun 15, 2021
entantoencuanto added a commit that referenced this pull request Jun 29, 2021
* develop: (47 commits)
  New Crowdin updates (#8150)
  Move the webpacker config override to @decidim/webpacker (#8158)
  Fix admin stylesheet dynamic imports (#8154)
  Fix session timeout conflicting with remember me (#7467)
  Allow to create online meetings without an URL (#8152)
  Fix verification route issues (#8146)
  Fix dont save timeout path to session (#8142)
  Fix access to import CSV results in accountability (#8132)
  Fix user report notification reported user name (#8130)
  Allow users to comment and delete their own comments (#8072)
  New Crowdin updates (#8124)
  Fix webpacker issues (#8136)
  Add comments in participatory space presentation page stats block (#8034)
  Split NPM dependencies to more granular packages (#8121)
  Metric is not shown when value is zero for blocked and reported users (#8117)
  Add missing templates translations (#8133)
  Add missing translation for authorization_modals (#8129)
  Polls in meetings (#8065)
  Fix flaky test on initiatives (#8128)
  Filter participants admin (#8104)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: admin type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants