Fix session timeout conflicting with remember me#7467
Merged
leio10 merged 16 commits intodecidim:developfrom Jun 23, 2021
Merged
Fix session timeout conflicting with remember me#7467leio10 merged 16 commits intodecidim:developfrom
leio10 merged 16 commits intodecidim:developfrom
Conversation
- Enable rememberable module only if expire_session_after isn't instance of ActiveSupport::Duration - Session expire warning and automatic sign_out now depends on expire_session_after time.
ahukkanen
requested changes
Feb 26, 2021
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
Maybe we could use durations primarily in the configurations not to mix'n'match different kinds of configuration options?
ahukkanen
reviewed
Feb 26, 2021
ahukkanen
reviewed
Feb 26, 2021
ahukkanen
reviewed
Feb 26, 2021
ahukkanen
reviewed
Feb 26, 2021
andreslucena
reviewed
Mar 1, 2021
12 tasks
ahukkanen
reviewed
Mar 3, 2021
Contributor
|
@lahdeero could you address @andreslucena's feedback, please? 😄 |
Contributor
|
@mrcasals We are waiting for @andreslucena input. |
Contributor
Author
|
@mrcasals or @leio10 can you review now please? @andreslucena has approved the changes |
entantoencuanto
added a commit
that referenced
this pull request
Jun 29, 2021
* develop: (47 commits) New Crowdin updates (#8150) Move the webpacker config override to @decidim/webpacker (#8158) Fix admin stylesheet dynamic imports (#8154) Fix session timeout conflicting with remember me (#7467) Allow to create online meetings without an URL (#8152) Fix verification route issues (#8146) Fix dont save timeout path to session (#8142) Fix access to import CSV results in accountability (#8132) Fix user report notification reported user name (#8130) Allow users to comment and delete their own comments (#8072) New Crowdin updates (#8124) Fix webpacker issues (#8136) Add comments in participatory space presentation page stats block (#8034) Split NPM dependencies to more granular packages (#8121) Metric is not shown when value is zero for blocked and reported users (#8117) Add missing templates translations (#8133) Add missing translation for authorization_modals (#8129) Polls in meetings (#8065) Fix flaky test on initiatives (#8128) Filter participants admin (#8104) ...
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After #7282 "remember_me" can be quite confusing, because we are singing users automatically out even if they have selected "remember me". Here we add new config "enable_remember_me" which is true by default. Also we stop automatically singing out users who have selected "remember me".
Additionally difference between Devise.timeout_in and Decidim.expire_session_after can be also confusing for system admins who are not familiar with rails. Here we combine Devise.timeout_in and Decidim.expire_session_after configs, so that Devise.timeout_in is set to same value as Decidim.expire_session_after.
📌 Related Issues
#7282
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.