Skip to content

Allow to create online meetings without an URL#8152

Merged
leio10 merged 3 commits intodevelopfrom
feat/not-required-meeting-url
Jun 23, 2021
Merged

Allow to create online meetings without an URL#8152
leio10 merged 3 commits intodevelopfrom
feat/not-required-meeting-url

Conversation

@leio10
Copy link
Copy Markdown
Contributor

@leio10 leio10 commented Jun 22, 2021

🎩 What? Why?

When creating an online meeting, sometimes the admin doesn't have the meeting URL. This PR allows to create the meeting without requiring to fill the URL field. In this case, the platform will show a "Link available soon" message instead of a link.

This PR also adds some validation for other URL fields in the project.

📌 Related Issues

Testing

  • Create an online meeting without an URL
  • Visit the meeting page and check the message shown.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Uploading imagen.png…

♥️ Thank you!

@leio10 leio10 merged commit 8bc49f9 into develop Jun 23, 2021
@leio10 leio10 deleted the feat/not-required-meeting-url branch June 23, 2021 14:39
entantoencuanto added a commit that referenced this pull request Jun 29, 2021
* develop: (47 commits)
  New Crowdin updates (#8150)
  Move the webpacker config override to @decidim/webpacker (#8158)
  Fix admin stylesheet dynamic imports (#8154)
  Fix session timeout conflicting with remember me (#7467)
  Allow to create online meetings without an URL (#8152)
  Fix verification route issues (#8146)
  Fix dont save timeout path to session (#8142)
  Fix access to import CSV results in accountability (#8132)
  Fix user report notification reported user name (#8130)
  Allow users to comment and delete their own comments (#8072)
  New Crowdin updates (#8124)
  Fix webpacker issues (#8136)
  Add comments in participatory space presentation page stats block (#8034)
  Split NPM dependencies to more granular packages (#8121)
  Metric is not shown when value is zero for blocked and reported users (#8117)
  Add missing templates translations (#8133)
  Add missing translation for authorization_modals (#8129)
  Polls in meetings (#8065)
  Fix flaky test on initiatives (#8128)
  Filter participants admin (#8104)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant