Skip to content

Fix admin stylesheet dynamic imports#8154

Merged
leio10 merged 3 commits intodecidim:developfrom
mainio:fix/admin-stylesheet-imports
Jun 23, 2021
Merged

Fix admin stylesheet dynamic imports#8154
leio10 merged 3 commits intodecidim:developfrom
mainio:fix/admin-stylesheet-imports

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Jun 23, 2021

🎩 What? Why?

As described at #8153, it was possible before to define admin stylesheet imports from the components.

After the webpacker migration this is no longer possible.

This PR adds this feature back by extending the implementation of #8115. This PR adds stylesheet import "groups" which can be then included separately for the app and admin groups.

📌 Related Issues

Testing

Define a component with an admin stylesheet:

Decidim.register_component(:foo) do |component|
  component.admin_stylesheet = "decidim/foo/admin"
end

Expect to see a difference in the admin styles. You won't see after the webpacker migration.

Note that the method above will not work after this is merged either, but this adds an alternative way to get the same functionality back with Webpacker.

Same with webpacker would be (after this PR):

# Inside decidim-foo module
# config/assets.rb
Decidim::Webpacker.register_stylesheet_import("stylesheets/decidim/foo/admin", group: :admin)

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 🔝 👏

@leio10 leio10 merged commit c0592e1 into decidim:develop Jun 23, 2021
@ahukkanen ahukkanen deleted the fix/admin-stylesheet-imports branch June 23, 2021 16:42
@ahukkanen ahukkanen restored the fix/admin-stylesheet-imports branch June 23, 2021 16:42
@ahukkanen ahukkanen deleted the fix/admin-stylesheet-imports branch June 23, 2021 16:42
entantoencuanto added a commit that referenced this pull request Jun 29, 2021
* develop: (47 commits)
  New Crowdin updates (#8150)
  Move the webpacker config override to @decidim/webpacker (#8158)
  Fix admin stylesheet dynamic imports (#8154)
  Fix session timeout conflicting with remember me (#7467)
  Allow to create online meetings without an URL (#8152)
  Fix verification route issues (#8146)
  Fix dont save timeout path to session (#8142)
  Fix access to import CSV results in accountability (#8132)
  Fix user report notification reported user name (#8130)
  Allow users to comment and delete their own comments (#8072)
  New Crowdin updates (#8124)
  Fix webpacker issues (#8136)
  Add comments in participatory space presentation page stats block (#8034)
  Split NPM dependencies to more granular packages (#8121)
  Metric is not shown when value is zero for blocked and reported users (#8117)
  Add missing templates translations (#8133)
  Add missing translation for authorization_modals (#8129)
  Polls in meetings (#8065)
  Fix flaky test on initiatives (#8128)
  Filter participants admin (#8104)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Webpacker: Dynamic admin stylesheet definition

3 participants