Move the webpacker config override to @decidim/webpacker#8158
Merged
leio10 merged 1 commit intodecidim:developfrom Jun 25, 2021
Merged
Move the webpacker config override to @decidim/webpacker#8158leio10 merged 1 commit intodecidim:developfrom
leio10 merged 1 commit intodecidim:developfrom
Conversation
leio10
approved these changes
Jun 25, 2021
Contributor
leio10
left a comment
There was a problem hiding this comment.
Awesome! Thanks for taking care of this! 👏🤩
Contributor
|
Hi @ahukkanen, this PR is breaking our staging app, do I have to add anything to the app to make it work? |
Contributor
Author
|
@leio10 I think it is #8154 that is breaking it. You need to update this: To match this: |
Contributor
|
Thanks @ahukkanen, it worked! ❤️ |
entantoencuanto
added a commit
that referenced
this pull request
Jun 29, 2021
* develop: (47 commits) New Crowdin updates (#8150) Move the webpacker config override to @decidim/webpacker (#8158) Fix admin stylesheet dynamic imports (#8154) Fix session timeout conflicting with remember me (#7467) Allow to create online meetings without an URL (#8152) Fix verification route issues (#8146) Fix dont save timeout path to session (#8142) Fix access to import CSV results in accountability (#8132) Fix user report notification reported user name (#8130) Allow users to comment and delete their own comments (#8072) New Crowdin updates (#8124) Fix webpacker issues (#8136) Add comments in participatory space presentation page stats block (#8034) Split NPM dependencies to more granular packages (#8121) Metric is not shown when value is zero for blocked and reported users (#8117) Add missing templates translations (#8133) Add missing translation for authorization_modals (#8129) Polls in meetings (#8065) Fix flaky test on initiatives (#8128) Filter participants admin (#8104) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This moves the configuration override for dynamic stylesheet includes implemented at #8115 to the
@decidim/webpackerpackage.This idea came from @ferblape's comment at #8115 (comment) where he mentioned this file might change during upgrades. At that point it wasn't possible to do but after #8121 was merged it is now possible to move these to the Decidim NPM packages.
We still need to override the import at
base.jsfile but this decouples the configuration overrides from that file to the@decidim/webpackerNPM package, so the changes needed atbase.jsare much more minimal.📌 Related Issues
Testing
./bin/webpack-dev-serverat the development appdecidim-budgets/app/packs/stylesheets/decidim/budgets/_budgets.scss-> addp{ color: #f00; }📋 Checklist
docs/.