Fix access to import CSV results in accountability#8132
Merged
leio10 merged 2 commits intodecidim:developfrom Jun 23, 2021
Merged
Fix access to import CSV results in accountability#8132leio10 merged 2 commits intodecidim:developfrom
leio10 merged 2 commits intodecidim:developfrom
Conversation
The override was not taking into account when accountability was in an assembly.
Contributor
Author
|
Hi @leio10 I've added a test to cover both scenarios, when the component is in a participatory_process and when it is in an assembly. It seems codecov/patch is asking for tests in resuts_controller which was not affected by the PR. Let me know if you need something else. |
leio10
approved these changes
Jun 23, 2021
Contributor
|
Thanks @tramuntanal! ❤️ Can you backport this PR for the version 0.24? |
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Jun 28, 2021
entantoencuanto
added a commit
that referenced
this pull request
Jun 29, 2021
* develop: (47 commits) New Crowdin updates (#8150) Move the webpacker config override to @decidim/webpacker (#8158) Fix admin stylesheet dynamic imports (#8154) Fix session timeout conflicting with remember me (#7467) Allow to create online meetings without an URL (#8152) Fix verification route issues (#8146) Fix dont save timeout path to session (#8142) Fix access to import CSV results in accountability (#8132) Fix user report notification reported user name (#8130) Allow users to comment and delete their own comments (#8072) New Crowdin updates (#8124) Fix webpacker issues (#8136) Add comments in participatory space presentation page stats block (#8034) Split NPM dependencies to more granular packages (#8121) Metric is not shown when value is zero for blocked and reported users (#8117) Add missing templates translations (#8133) Add missing translation for authorization_modals (#8129) Polls in meetings (#8065) Fix flaky test on initiatives (#8128) Filter participants admin (#8104) ...
tramuntanal
added a commit
to CodiTramuntana/decidim
that referenced
this pull request
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
decidim-accountability/app/controllers/decidim/accountability/admin/import_results_controller.rbwas incorrectly overriding the methodscurrent_component¤t_participatory_process, this PR removes this overrides. The override was not taking into account when accountability was in an assembly.📌 Related Issues
Link your PR to an issue
Testing
Go to the accountability component of an assembly and click the "Import CSV" button.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
In an Assembly
In a Participatory Process
