refactor: Federation refactor towards services + file names improvement + E2E tests fixes#28326
Merged
Conversation
added 4 commits
February 28, 2023 13:38
…ase (#28158) * fix: fix e2e tests based on selector changes made in the latest release * fix: fix more tests
…at into feat/federation-6.1
* chore: move federation to an internal service * fix: fix tests * test: fix test
* chore: move federation to an internal service * fix: fix tests * chore: move federation from app folder to server * test: fix test * fix: fix mistakes from merge
Codecov Report
@@ Coverage Diff @@
## develop #28326 +/- ##
============================================
+ Coverage 32.62% 45.33% +12.70%
============================================
Files 621 759 +138
Lines 12368 14782 +2414
Branches 1863 2083 +220
============================================
+ Hits 4035 6701 +2666
+ Misses 8135 7789 -346
- Partials 198 292 +94
Flags with carried forward coverage won't be shown. Click here to find out more. |
* chore: move federation to an internal service * fix: fix tests * chore: move federation from app folder to server * chore: improve folder names and file names * test: fix test * refactor: rename class property * fix: fix tests
lmauromb
previously approved these changes
Mar 8, 2023
pierre-lehnen-rc
previously approved these changes
Mar 8, 2023
8ba478d
pierre-lehnen-rc
approved these changes
Mar 10, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 13, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch * 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits) refactor: Replace `_.isObject` with `isObject` (#28376) fix: small tweaks chore: Remove old css (#28140) fix: Thread list not scrolling to bottom when sending a message. (#28346) refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326) i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365) refactor: Improve sidebar search list hook (#28328) Chore: Change the PR title check to use conventional commits (#28358) [IMPROVE] Galician onboarding translation (#27908) [IMPROVE] Adding input type=password to AWS secrets fields (#28159) [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187) Chore: remove unused prop in register workspace modal (#28317) [FIX] App crashing when switching to Hindi (hi-In) language (#28285) [NEW] Registered Loom oEmbed (#28339) fix: create dm users before join the room tests: add unit tests + small tweaks fix: fix invite links button logic chore: fix lint Chore: Remove/replace some Meteor packages (#28189) Chore: Unused/dead code removal (#28155) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR is the one that groups the other 4 PRs related to refactoring federation moving from the regular "app" folder to the new services implementation, it also refactors some files and folders to more meaningful and finally it fix some E2E tests.
#28263
#28267
#28295
#28158
Issue(s)
Steps to test or reproduce
Further comments