Chore: Convert Federation to internal service#28263
Merged
MarcosSpessatto merged 6 commits intoMar 7, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/federation-6.1 #28263 +/- ##
======================================================
Coverage ? 44.95%
======================================================
Files ? 771
Lines ? 14984
Branches ? 2091
======================================================
Hits ? 6736
Misses ? 7951
Partials ? 297
Flags with carried forward coverage won't be shown. Click here to find out more. |
added 4 commits
March 4, 2023 11:35
….com:RocketChat/Rocket.Chat into chore/convert-federation-to-internal-service
lmauromb
approved these changes
Mar 7, 2023
pierre-lehnen-rc
approved these changes
Mar 7, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 23, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch * 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: tests: fix e2e tests tests: fix e2e tests fix: small tweaks fix: create dm users before join the room tests: add unit tests + small tweaks fix: fix invite links button logic chore: fix lint feat: support to join public rooms(join, UI, invite link) feat: support for public room search (WIP) Chore: Improve Federation folder naming and file naming (#28295) Chore: Move Federation from app folder to server (#28267) Chore: Convert Federation to internal service (#28263) [FIX] Fix e2e tests based on selector changes made in the latest release (#28158)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
The goal of this PR is to move all the Matrix Federation bootstrap to a centralized place (Services). Today we have that in 2 different places, a portion of the bootstrap on the index file (inside
/apps/meteor/app) and another portion inside a Service actually, which lead to confusion.The idea is to create a new Federation Service for the EE stuff, the CE Service already exists, move everything to be bootstrapped inside of it, and finally kill both index(es) files from either CE and EE (
apps/meteor/app).We'll also leverage this movement in the future in case we want to migrate to MS architecture.
I didn't change anything on the code behavior itself, the changes were made only to achieve the main purpose of the PR. The only exception was to move 2 methods from a EE class to a CE one, created wrongly in the EE environment.
Part of Jira: FED-90
Issue(s)
Steps to test or reproduce
Further comments