Skip to content

Chore: Improve Federation folder naming and file naming#28295

Merged
MarcosSpessatto merged 15 commits into
feat/federation-6.1from
chore/federation/better-naming-and-foldering
Mar 8, 2023
Merged

Chore: Improve Federation folder naming and file naming#28295
MarcosSpessatto merged 15 commits into
feat/federation-6.1from
chore/federation/better-naming-and-foldering

Conversation

@MarcosSpessatto

@MarcosSpessatto MarcosSpessatto commented Mar 6, 2023

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Depends on #28267

The intention of this PR is to improve the folder structure of the Federation project + improve the name quality of some folders/files/classes/methods/variables. This does not change any behavior, the only idea is to improve the structure itself.

Part of Jira: FED-90

Issue(s)

Steps to test or reproduce

Further comments

@MarcosSpessatto MarcosSpessatto requested a review from lmauromb March 6, 2023 16:00
@MarcosSpessatto MarcosSpessatto self-assigned this Mar 6, 2023
@MarcosSpessatto MarcosSpessatto changed the title Chore: Improve Federation folder names and file naming Chore: Improve Federation folder naming and file naming Mar 6, 2023
@codecov

codecov Bot commented Mar 6, 2023

Copy link
Copy Markdown

Codecov Report

Merging #28295 (54cf7af) into feat/federation-6.1 (3069da1) will increase coverage by 6.59%.
The diff coverage is n/a.

Impacted file tree graph

@@                   Coverage Diff                   @@
##           feat/federation-6.1   #28295      +/-   ##
=======================================================
+ Coverage                32.47%   39.06%   +6.59%     
=======================================================
  Files                      634      732      +98     
  Lines                    12568    14439    +1871     
  Branches                  1869     2047     +178     
=======================================================
+ Hits                      4081     5641    +1560     
- Misses                    8286     8514     +228     
- Partials                   201      284      +83     
Flag Coverage Δ
e2e 39.06% <ø> (+6.58%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Marcos Defendi added 4 commits March 6, 2023 14:42
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review March 6, 2023 19:11
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner March 6, 2023 19:11
Base automatically changed from chore/move-federation-from-app-to-server to feat/federation-6.1 March 7, 2023 17:35
@MarcosSpessatto MarcosSpessatto merged commit 29a80aa into feat/federation-6.1 Mar 8, 2023
@MarcosSpessatto MarcosSpessatto deleted the chore/federation/better-naming-and-foldering branch March 8, 2023 11:51
gabriellsh added a commit that referenced this pull request Mar 23, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch

* 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat:
  tests: fix e2e tests
  tests: fix e2e tests
  fix: small tweaks
  fix: create dm users before join the room
  tests: add unit tests + small tweaks
  fix: fix invite links button logic
  chore: fix lint
  feat: support to join public rooms(join, UI, invite link)
  feat: support for public room search (WIP)
  Chore: Improve Federation folder naming and file naming (#28295)
  Chore: Move Federation from app folder to server (#28267)
  Chore: Convert Federation to internal service (#28263)
  [FIX] Fix e2e tests based on selector changes made in the latest release (#28158)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants