Skip to content

Chore: Move Federation from app folder to server#28267

Merged
MarcosSpessatto merged 11 commits into
feat/federation-6.1from
chore/move-federation-from-app-to-server
Mar 7, 2023
Merged

Chore: Move Federation from app folder to server#28267
MarcosSpessatto merged 11 commits into
feat/federation-6.1from
chore/move-federation-from-app-to-server

Conversation

@MarcosSpessatto

@MarcosSpessatto MarcosSpessatto commented Mar 3, 2023

Copy link
Copy Markdown
Contributor

Proposed changes (including videos or screenshots)

Depends on #28263

This PR's goal is to move all the Federation code from the app/federation-v2 folder ("legacy-mode") to the new Services approach. This helps us to keep with the guidelines proposed by the engineering team, besides giving us better flexibility in the near future if we want to move the service to the MS architecture.

Part of Jira: FED-90

Issue(s)

Steps to test or reproduce

Further comments

@codecov

codecov Bot commented Mar 3, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (feat/federation-6.1@1b91838). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                   @@
##             feat/federation-6.1   #28267   +/-   ##
======================================================
  Coverage                       ?   44.90%           
======================================================
  Files                          ?      771           
  Lines                          ?    14984           
  Branches                       ?     2091           
======================================================
  Hits                           ?     6728           
  Misses                         ?     7958           
  Partials                       ?      298           
Flag Coverage Δ
e2e 44.86% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Marcos Defendi added 4 commits March 6, 2023 14:42
@MarcosSpessatto MarcosSpessatto marked this pull request as ready for review March 6, 2023 19:02
@MarcosSpessatto MarcosSpessatto requested a review from a team as a code owner March 6, 2023 19:02
Base automatically changed from chore/convert-federation-to-internal-service to feat/federation-6.1 March 7, 2023 16:32
@MarcosSpessatto MarcosSpessatto merged commit d4e9906 into feat/federation-6.1 Mar 7, 2023
@MarcosSpessatto MarcosSpessatto deleted the chore/move-federation-from-app-to-server branch March 7, 2023 17:35
gabriellsh added a commit that referenced this pull request Mar 23, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch

* 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat:
  tests: fix e2e tests
  tests: fix e2e tests
  fix: small tweaks
  fix: create dm users before join the room
  tests: add unit tests + small tweaks
  fix: fix invite links button logic
  chore: fix lint
  feat: support to join public rooms(join, UI, invite link)
  feat: support for public room search (WIP)
  Chore: Improve Federation folder naming and file naming (#28295)
  Chore: Move Federation from app folder to server (#28267)
  Chore: Convert Federation to internal service (#28263)
  [FIX] Fix e2e tests based on selector changes made in the latest release (#28158)
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants