[FIX] Fix e2e tests based on selector changes made in the latest release#28158
Merged
MarcosSpessatto merged 3 commits intoFeb 28, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## feat/federation-6.1 #28158 +/- ##
=======================================================
- Coverage 44.93% 35.68% -9.25%
=======================================================
Files 766 707 -59
Lines 14903 14205 -698
Branches 2070 2010 -60
=======================================================
- Hits 6696 5069 -1627
- Misses 7915 8876 +961
+ Partials 292 260 -32
Flags with carried forward coverage won't be shown. Click here to find out more. |
alansikora
approved these changes
Feb 27, 2023
lmauromb
approved these changes
Feb 27, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 23, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch * 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: tests: fix e2e tests tests: fix e2e tests fix: small tweaks fix: create dm users before join the room tests: add unit tests + small tweaks fix: fix invite links button logic chore: fix lint feat: support to join public rooms(join, UI, invite link) feat: support for public room search (WIP) Chore: Improve Federation folder naming and file naming (#28295) Chore: Move Federation from app folder to server (#28267) Chore: Convert Federation to internal service (#28263) [FIX] Fix e2e tests based on selector changes made in the latest release (#28158)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
This PR just fixes some changes that were made in the selectors and some behaviors that were changed in the latest release. We need to do that because federation tests don't run on CI, so there is no way (until now) to figure out those changes unless running everything locally.
Jira: FED-86
Issue(s)
Steps to test or reproduce
Further comments