Skip to content

Chore: Change the PR title check to use conventional commits#28358

Merged
sampaiodiego merged 4 commits into
developfrom
ci/conventional-commits
Mar 10, 2023
Merged

Chore: Change the PR title check to use conventional commits#28358
sampaiodiego merged 4 commits into
developfrom
ci/conventional-commits

Conversation

@ggazzo

@ggazzo ggazzo commented Mar 10, 2023 •
edited by sampaiodiego
Loading

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

The new regex can be tested at https://regex101.com/r/dLCjJN/1

This is the sample text used:

feat: ok
fix(package): ok
ci!: breaking ok
chore(package)!: breaking ok
i18n: ok
Release 1.2.3
Merge master into develop
Bump something ok

docs fail
test(: fail
refactor(package):fail
[NEW] fail
[FIX] fail

@ggazzo ggazzo force-pushed the ci/conventional-commits branch from 575b0a2 to 2639f27 Compare March 10, 2023 13:00
@ggazzo ggazzo changed the title ci: Change the pr title validations to use Conventional Commits ci: Change the pr title validations to use conventional commits Mar 10, 2023
@ggazzo ggazzo changed the title ci: Change the pr title validations to use conventional commits Chore: Change the pr title validations to use conventional commits Mar 10, 2023
@codecov

codecov Bot commented Mar 10, 2023 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #28358 (2639f27) into develop (35fadd0) will decrease coverage by 0.12%.
The diff coverage is n/a.

❗ Current head 2639f27 differs from pull request most recent head ef3092d. Consider uploading reports for the commit ef3092d to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28358      +/-   ##
===========================================
- Coverage    45.25%   45.14%   -0.12%     
===========================================
  Files          759      759              
  Lines        14784    14784              
  Branches      2085     2085              
===========================================
- Hits          6691     6674      -17     
- Misses        7798     7816      +18     
+ Partials       295      294       -1
Flag Coverage Δ
e2e 45.10% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ggazzo ggazzo changed the title Chore: Change the pr title validations to use conventional commits ci: Change the pr title validations to use conventional commits Mar 10, 2023
@ggazzo ggazzo changed the title ci: Change the pr title validations to use conventional commits [NEW] Change the pr title validations to use conventional commits Mar 10, 2023
@sampaiodiego sampaiodiego changed the title [NEW] Change the pr title validations to use conventional commits ci: Change the pr title validations to use conventional commits Mar 10, 2023
@sampaiodiego sampaiodiego changed the title ci: Change the pr title validations to use conventional commits Chore: Change the pr title validations to use conventional commits Mar 10, 2023
@sampaiodiego sampaiodiego changed the title Chore: Change the pr title validations to use conventional commits Chore: Change the PR title check to use conventional commits Mar 10, 2023
@sampaiodiego sampaiodiego marked this pull request as ready for review March 10, 2023 17:27
@sampaiodiego sampaiodiego requested a review from a team as a code owner March 10, 2023 17:27
@sampaiodiego sampaiodiego merged commit b70074b into develop Mar 10, 2023
@sampaiodiego sampaiodiego deleted the ci/conventional-commits branch March 10, 2023 17:27
gabriellsh added a commit that referenced this pull request Mar 13, 2023
@gabriellsh
Merge branch 'feat/federation-public-room-search-2' of github.com:Roc…
f3a54f7 
…ketChat/Rocket.Chat into matrixSearchTestBranch

* 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits)
  refactor: Replace `_.isObject` with `isObject` (#28376)
  fix: small tweaks
  chore: Remove old css (#28140)
  fix: Thread list not scrolling to bottom when sending a message. (#28346)
  refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326)
  i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365)
  refactor: Improve sidebar search list hook (#28328)
  Chore: Change the PR title check to use conventional commits (#28358)
  [IMPROVE] Galician onboarding translation (#27908)
  [IMPROVE] Adding input type=password to AWS secrets fields (#28159)
  [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187)
  Chore: remove unused prop in register workspace modal (#28317)
  [FIX] App crashing when switching to Hindi (hi-In) language (#28285)
  [NEW] Registered Loom oEmbed (#28339)
  fix: create dm users before join the room
  tests: add unit tests + small tweaks
  fix: fix invite links button logic
  chore: fix lint
  Chore: Remove/replace some Meteor packages (#28189)
  Chore: Unused/dead code removal (#28155)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sampaiodiego sampaiodiego sampaiodiego approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ggazzo @sampaiodiego