[FIX] App crashing when switching to Hindi (hi-In) language#28285
Merged
Conversation
Contributor
Author
|
@dudanogueira & @dougfabris can you please review this |
Contributor
|
Thank you for your contribution 👏 |
hugocostadev
approved these changes
Mar 6, 2023
Contributor
Author
|
@hugocostadev , I think some error occurred during testing, Can you please review this again? |
Codecov Report
@@ Coverage Diff @@
## develop #28285 +/- ##
===========================================
- Coverage 45.25% 45.20% -0.06%
===========================================
Files 759 759
Lines 14784 14784
Branches 2085 2085
===========================================
- Hits 6691 6683 -8
- Misses 7798 7805 +7
- Partials 295 296 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
added a commit
that referenced
this pull request
Mar 13, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch * 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits) refactor: Replace `_.isObject` with `isObject` (#28376) fix: small tweaks chore: Remove old css (#28140) fix: Thread list not scrolling to bottom when sending a message. (#28346) refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326) i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365) refactor: Improve sidebar search list hook (#28328) Chore: Change the PR title check to use conventional commits (#28358) [IMPROVE] Galician onboarding translation (#27908) [IMPROVE] Adding input type=password to AWS secrets fields (#28159) [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187) Chore: remove unused prop in register workspace modal (#28317) [FIX] App crashing when switching to Hindi (hi-In) language (#28285) [NEW] Registered Loom oEmbed (#28339) fix: create dm users before join the room tests: add unit tests + small tweaks fix: fix invite links button logic chore: fix lint Chore: Remove/replace some Meteor packages (#28189) Chore: Unused/dead code removal (#28155) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Fixed app crashing when switching to Hindi (hi-in) language
The bug was mainly caused by a mismatch in file names between the language library used and the one used in the project. The language library used a key of 'hi', while the project used 'hi-in', resulting in the problem.
For solving this issue
Renamed file 'hi-IN.i18n.json' to 'hi.i18n.json' and checked it on my local environment and it works fine. Please review this.
Rocket.chat.issue.mp4
Issue(s)
closes #28280
Steps to test or reproduce
Further comments