Skip to content

Chore: Unused/dead code removal#28155

Merged
ggazzo merged 9 commits into
developfrom
chore/modules-housekeeping
Mar 9, 2023
Merged

Chore: Unused/dead code removal#28155
ggazzo merged 9 commits into
developfrom
chore/modules-housekeeping

Conversation

@tassoevan

Copy link
Copy Markdown
Member

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

@codecov

codecov Bot commented Feb 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #28155 (444cd82) into develop (c11758c) will increase coverage by 0.18%.
The diff coverage is 56.25%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #28155      +/-   ##
===========================================
+ Coverage    44.97%   45.15%   +0.18%     
===========================================
  Files          771      759      -12     
  Lines        14980    14784     -196     
  Branches      2092     2085       -7     
===========================================
- Hits          6737     6676      -61     
+ Misses        7947     7814     -133     
+ Partials       296      294       -2     
Flag Coverage Δ
e2e 45.11% <56.25%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the chore/modules-housekeeping branch 2 times, most recently from 5009719 to 8ca85a0 Compare February 25, 2023 01:24
@tassoevan tassoevan force-pushed the chore/modules-housekeeping branch from 8ca85a0 to 6314f94 Compare February 25, 2023 02:10
@tassoevan tassoevan changed the title Chore: chore/modules-housekeeping Chore: Unused/dead code removal Feb 25, 2023
@tassoevan tassoevan marked this pull request as ready for review February 25, 2023 03:11
@tassoevan tassoevan requested review from a team as code owners February 25, 2023 03:11
@tassoevan tassoevan added this to the 6.1.0 milestone Mar 1, 2023
@ggazzo ggazzo merged commit 05a9c01 into develop Mar 9, 2023
@ggazzo ggazzo deleted the chore/modules-housekeeping branch March 9, 2023 21:50
gabriellsh added a commit that referenced this pull request Mar 13, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch

* 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits)
  refactor: Replace `_.isObject` with `isObject` (#28376)
  fix: small tweaks
  chore: Remove old css (#28140)
  fix: Thread list not scrolling to bottom when sending a message. (#28346)
  refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326)
  i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365)
  refactor: Improve sidebar search list hook (#28328)
  Chore: Change the PR title check to use conventional commits (#28358)
  [IMPROVE] Galician onboarding translation (#27908)
  [IMPROVE] Adding input type=password to AWS secrets fields (#28159)
  [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187)
  Chore: remove unused prop in register workspace modal (#28317)
  [FIX] App crashing when switching to Hindi (hi-In) language (#28285)
  [NEW] Registered Loom oEmbed (#28339)
  fix: create dm users before join the room
  tests: add unit tests + small tweaks
  fix: fix invite links button logic
  chore: fix lint
  Chore: Remove/replace some Meteor packages (#28189)
  Chore: Unused/dead code removal (#28155)
  ...
@casalsgh casalsgh modified the milestones: 6.1.0, 6.2.0 Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants