[IMPROVE] Adding input type=password to AWS secrets fields#28159
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #28159 +/- ##
============================================
+ Coverage 32.61% 45.22% +12.60%
============================================
Files 621 759 +138
Lines 12367 14784 +2417
Branches 1862 2085 +223
============================================
+ Hits 4034 6686 +2652
+ Misses 8135 7804 -331
- Partials 198 294 +96
Flags with carried forward coverage won't be shown. Click here to find out more. |
gabriellsh
approved these changes
Feb 24, 2023
gabriellsh
added a commit
that referenced
this pull request
Mar 13, 2023
…ketChat/Rocket.Chat into matrixSearchTestBranch * 'feat/federation-public-room-search-2' of github.com:RocketChat/Rocket.Chat: (42 commits) refactor: Replace `_.isObject` with `isObject` (#28376) fix: small tweaks chore: Remove old css (#28140) fix: Thread list not scrolling to bottom when sending a message. (#28346) refactor: Federation refactor towards services + file names improvement + E2E tests fixes (#28326) i18n: Language update from LingoHub 🤖 on 2023-03-10Z (#28365) refactor: Improve sidebar search list hook (#28328) Chore: Change the PR title check to use conventional commits (#28358) [IMPROVE] Galician onboarding translation (#27908) [IMPROVE] Adding input type=password to AWS secrets fields (#28159) [FIX] Normal and multiline messages adding extra spaces upon copying/pasting (#28187) Chore: remove unused prop in register workspace modal (#28317) [FIX] App crashing when switching to Hindi (hi-In) language (#28285) [NEW] Registered Loom oEmbed (#28339) fix: create dm users before join the room tests: add unit tests + small tweaks fix: fix invite links button logic chore: fix lint Chore: Remove/replace some Meteor packages (#28189) Chore: Unused/dead code removal (#28155) ...
sampaiodiego
pushed a commit
that referenced
this pull request
Mar 27, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Some fields that store secrets for AWS were exposing sensitive data because they didn't have the input type as
password.The change includes adding the password type and also changing the autocomplete value from
<PasswordInput />component to add the valuenew-passwordto avoid the browser autocompleting with the existing password. (This does not prevent the browser to show the hint to add the password)Issue(s)
Steps to test or reproduce
GO to admin panel > settings > file upload > amazon S3
Further comments
TC-498